Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2225723005: [Findit] Add WfSuspectedCL model to save triage results for each suspected CL. (Closed)

Created:
4 years, 4 months ago by chanli
Modified:
4 years, 4 months ago
Reviewers:
Sharu Jiang, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Add WfSuspectedCL model to save triage results for each suspected CL. BUG= Committed: https://chromium.googlesource.com/infra/infra/+/6a04a7dbba12c2426142ec813ff8b6e91e52443b

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -61 lines) Patch
A appengine/findit/model/analysis_approach_type.py View 1 1 chunk +15 lines, -0 lines 0 comments Download
M appengine/findit/model/test/wf_culprit_test.py View 1 chunk +0 lines, -6 lines 0 comments Download
A appengine/findit/model/test/wf_suspected_cl_test.py View 1 chunk +13 lines, -0 lines 0 comments Download
M appengine/findit/model/wf_culprit.py View 2 chunks +2 lines, -34 lines 0 comments Download
A + appengine/findit/model/wf_suspected_cl.py View 1 chunk +15 lines, -21 lines 0 comments Download

Depends on Patchset:

Issue 2187763004 Patch 120001

Messages

Total messages: 11 (4 generated)
chanli
PTAL
4 years, 4 months ago (2016-08-08 17:12:40 UTC) #2
lijeffrey
lgtm with a nit https://codereview.chromium.org/2225723005/diff/1/appengine/findit/model/approach_type.py File appengine/findit/model/approach_type.py (right): https://codereview.chromium.org/2225723005/diff/1/appengine/findit/model/approach_type.py#newcode3 appengine/findit/model/approach_type.py:3: # found in the LICENSE ...
4 years, 4 months ago (2016-08-09 04:14:47 UTC) #3
chanli
4 years, 4 months ago (2016-08-09 17:15:29 UTC) #4
lijeffrey
lgtm
4 years, 4 months ago (2016-08-09 22:27:15 UTC) #5
Sharu Jiang
lgtm
4 years, 4 months ago (2016-08-12 02:45:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225723005/40001
4 years, 4 months ago (2016-08-15 20:50:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:04:36 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/6a04a7dbba12c2426142ec813ff8b...

Powered by Google App Engine
This is Rietveld 408576698