Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2880)

Unified Diff: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

Issue 2187763004: [Findit] Refactor Findit pipeline. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
diff --git a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
index 84e5c5bc96db4d56d3ea8f750083250c9c81677b..e59c99796299dd9c27f06438fab9edfa1bc48c54 100644
--- a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
+++ b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
@@ -10,12 +10,12 @@ from google.appengine.ext import ndb
from common.git_repository import GitRepository
from common.http_client_appengine import HttpClientAppengine as HttpClient
from common.pipeline_wrapper import BasePipeline
+from common.waterfall import failure_type
from model import analysis_status
from model import result_status
from model.wf_analysis import WfAnalysis
from model.wf_try_job import WfTryJob
from model.wf_try_job_data import WfTryJobData
-from waterfall.try_job_type import TryJobType
from waterfall.send_notification_for_culprit_pipeline import (
SendNotificationForCulpritPipeline)
@@ -280,7 +280,7 @@ class IdentifyTryJobCulpritPipeline(BasePipeline):
culprits = None
if result and result.get('report'):
try_job_data = WfTryJobData.Get(try_job_id)
- if try_job_type == TryJobType.COMPILE:
+ if try_job_type == failure_type.COMPILE:
# For compile failures, the try job will stop if one revision fails, so
# the culprit will be the last revision in the result.
failed_revision = _GetFailedRevisionFromCompileResult(result)
@@ -307,7 +307,7 @@ class IdentifyTryJobCulpritPipeline(BasePipeline):
if culprits:
result_to_update = (
try_job_result.compile_results if
- try_job_type == TryJobType.COMPILE else
+ try_job_type == failure_type.COMPILE else
try_job_result.test_results)
if (result_to_update and
result_to_update[-1]['try_job_id'] == try_job_id):
« no previous file with comments | « appengine/findit/waterfall/analyze_build_failure_pipeline.py ('k') | appengine/findit/waterfall/monitor_try_job_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698