Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3304)

Unified Diff: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Issue 2187763004: [Findit] Refactor Findit pipeline. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
index 826727aff0c922fcc6ff3559dcfdf789d8e8a62c..3530cf79761d0c41143bcb564fe4c3bfda3e4229 100644
--- a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
@@ -7,6 +7,7 @@ import json
import time
from common.waterfall import buildbucket_client
+from common.waterfall import failure_type
from common.waterfall import try_job_error
from model import analysis_status
from model.wf_try_job import WfTryJob
@@ -15,7 +16,6 @@ from waterfall import monitor_try_job_pipeline
from waterfall import waterfall_config
from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline
from waterfall.test import wf_testcase
-from waterfall.try_job_type import TryJobType
# A counter to enable different responses to requests in a loop.
@@ -216,7 +216,7 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
pipeline = MonitorTryJobPipeline()
compile_result = pipeline.run(
- master_name, builder_name, build_number, TryJobType.COMPILE,
+ master_name, builder_name, build_number, failure_type.COMPILE,
try_job_id)
expected_compile_result = {
@@ -266,7 +266,7 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
pipeline = MonitorTryJobPipeline()
test_result = pipeline.run(
- master_name, builder_name, build_number, TryJobType.TEST,
+ master_name, builder_name, build_number, failure_type.TEST,
try_job_id)
expected_test_result = {
@@ -307,7 +307,7 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
pipeline = MonitorTryJobPipeline()
pipeline._UpdateTryJobResult(
buildbucket_client.BuildbucketBuild.STARTED, master_name, builder_name,
- build_number, TryJobType.TEST, try_job_id, 'url')
+ build_number, failure_type.TEST, try_job_id, 'url')
try_job = WfTryJob.Get(master_name, builder_name, build_number)
self.assertEqual(analysis_status.RUNNING, try_job.status)

Powered by Google App Engine
This is Rietveld 408576698