[Findit] Refactor Findit pipeline.

appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from testing_utils import testing
 
 from common.git_repository import GitRepository
+from common.waterfall import failure_type
 from model import analysis_status
 from model import result_status
 from model.wf_analysis import WfAnalysis
 from model.wf_try_job import WfTryJob
 from model.wf_try_job_data import WfTryJobData
 from waterfall import identify_try_job_culprit_pipeline
 from waterfall.identify_try_job_culprit_pipeline import(
     IdentifyTryJobCulpritPipeline)
-from waterfall.try_job_type import TryJobType
 
 
 class IdentifyTryJobCulpritPipelineTest(testing.AppengineTestCase):
-
   def _MockGetChangeLog(self, revision):

[lijeffrey, 2016/08/04 10:31:47]

should the empty line be kept?

[chanli, 2016/08/05 19:53:54]

Done.

     class MockedChangeLog(object):
 
       def __init__(self, commit_position, code_review_url):
         self.commit_position = commit_position
         self.code_review_url = code_review_url
 
     mock_change_logs = {}
     mock_change_logs['rev1'] = MockedChangeLog('1', 'url_1')
     mock_change_logs['rev2'] = MockedChangeLog('2', 'url_2')
     return mock_change_logs.get(revision)
@@ skipping 352 matching lines @@
     try_job.put()
     try_job_data = WfTryJobData.Create(try_job_id)
     try_job_data.put()
 
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1'],
-        TryJobType.COMPILE, '1', None)
+        failure_type.COMPILE, '1', None)
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     self.assertEqual(analysis_status.COMPLETED, try_job.status)
     self.assertEqual([], try_job.compile_results)
     self.assertIsNone(culprit)
     self.assertIsNone(try_job_data.culprits)
     self.assertIsNone(analysis.result_status)
     self.assertIsNone(analysis.suspected_cls)
 
   def testIdentifyCulpritForCompileTryJobSuccess(self):
@@ skipping 25 matching lines @@
         },
         'try_job_id': try_job_id,
     }]
     try_job.put()
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1'],
-        TryJobType.COMPILE, '1', compile_result)
+        failure_type.COMPILE, '1', compile_result)
 
     expected_culprit = 'rev2'
     expected_suspected_cl = {
         'revision': 'rev2',
         'commit_position': '2',
         'url': 'url_2',
         'repo_name': 'chromium'
     }
     expected_compile_result = {
         'report': {
@@ skipping 40 matching lines @@
     }
 
     WfTryJobData.Create(try_job_id).put()
     WfTryJob.Create(master_name, builder_name, build_number).put()
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1'],
-        TryJobType.COMPILE, '1', compile_result)
+        failure_type.COMPILE, '1', compile_result)
     try_job = WfTryJob.Get(master_name, builder_name, build_number)
 
     self.assertIsNone(culprit)
     self.assertEqual(analysis_status.COMPLETED, try_job.status)
 
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.culprits)
 
     self.assertIsNone(analysis.result_status)
     self.assertIsNone(analysis.suspected_cls)
 
   def testIdentifyCulpritForTestTryJobNoTryJobResultNoHeuristicResult(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 1
     try_job_id = '1'
 
     WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
-        TryJobType.TEST, '1', None)
+        failure_type.TEST, '1', None)
 
     self.assertIsNone(culprit)
 
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.culprits)
     self.assertIsNone(analysis.result_status)
     self.assertIsNone(analysis.suspected_cls)
 
   def testIdentifyCulpritForTestTryJobNoTryJobResultWithHeuristicResult(self):
     master_name = 'm'
@@ skipping 15 matching lines @@
 
     # Heuristic analysis already provided some results.
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.result_status = result_status.FOUND_UNTRIAGED
     analysis.suspected_cls = [suspected_cl]
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
-        TryJobType.TEST, '1', None)
+        failure_type.TEST, '1', None)
 
     self.assertIsNone(culprit)
 
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.culprits)
 
     # Ensure analysis results are not updated since no culprit from try job.
     self.assertEqual(analysis.result_status, result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls, [suspected_cl])
 
@@ skipping 21 matching lines @@
 
     WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
-        master_name, builder_name, build_number, [], TryJobType.TEST, '1',
+        master_name, builder_name, build_number, [], failure_type.TEST, '1',
         test_result)
 
     self.assertIsNone(culprit)
 
     try_job_data = WfTryJobData.Get(try_job_id)
     self.assertIsNone(try_job_data.culprits)
 
     self.assertIsNone(analysis.result_status)
     self.assertIsNone(analysis.suspected_cls)
 
@@ skipping 21 matching lines @@
 
     WfTryJobData.Create(try_job_id).put()
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.put()
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
-        master_name, builder_name, build_number, ['rev3'], TryJobType.TEST,
+        master_name, builder_name, build_number, ['rev3'], failure_type.TEST,
         '1', test_result)
 
     expected_suspected_cl = {
         'revision': 'rev3',
         'repo_name': 'chromium'
     }
 
     expected_culprit = {
         'a_test': {
             'tests': {
@@ skipping 66 matching lines @@
     try_job = WfTryJob.Create(master_name, builder_name, build_number)
     try_job.status = analysis_status.RUNNING
     try_job.test_results = [test_result]
     try_job.put()
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     culprit = pipeline.run(
         master_name, builder_name, build_number, ['rev1', 'rev2'],
-        TryJobType.TEST, '1', test_result)
+        failure_type.TEST, '1', test_result)
 
     a_test1_suspected_cl = {
         'revision': 'rev1',
         'commit_position': '1',
         'url': 'url_1',
         'repo_name': 'chromium'
     }
     a_test2_suspected_cl = {
         'revision': 'rev2',
         'commit_position': '2',
@@ skipping 125 matching lines @@
                 'rev1': 'failed',
             },
         },
         'try_job_id': try_job_id,
     }]
 
     try_job.put()
 
     pipeline = IdentifyTryJobCulpritPipeline()
     pipeline.run(master_name, builder_name, build_number, ['rev1'],
-                 TryJobType.COMPILE, '1', compile_result)
+                 failure_type.COMPILE, '1', compile_result)
 
     self.assertEqual(analysis.result_status,
                      result_status.FOUND_UNTRIAGED)
     self.assertEqual(analysis.suspected_cls, [suspected_cl])
     self.assertEqual(version, analysis.version)  # No update to analysis.
 
   def testFindCulpritForEachTestFailureRevisionNotRun(self):
     blame_list = ['rev1']
     result = {
         'report': {
@@ skipping 56 matching lines @@
     culprits = {
         'r1': {
             'repo_name': 'chromium',
             'revision': 'r1',
         }
     }
 
     identify_try_job_culprit_pipeline._NotifyCulprits('m', 'b', 1, culprits)
     self.assertEqual(1, len(instances))
     self.assertTrue(instances[0].started)