appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py - Issue 2187763004: [Findit] Refactor Findit pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

Issue 2187763004: [Findit] Refactor Findit pipeline. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py ('k') | appengine/findit/waterfall/test/run_try_job_for_reliable_failure_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py b/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

index 1bd527fa40442da05f38c1e36f9bf0e5c09ab6d9..aecef2b403d3a9637bf4f9b5d056b6d7afa0fb2a 100644

--- a/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

+++ b/appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py

@@ -173,7 +173,7 @@ class ProcessSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):

self.assertEqual(self.step_name, step_name)

self.assertEqual('abc_tests', task_info[0])

- self.assertEqual(_EXPECTED_CLASSIFIED_TESTS, task_info[1])

+ self.assertEqual(_EXPECTED_CLASSIFIED_TESTS['reliable_tests'], task_info[1])

task = WfSwarmingTask.Get(

self.master_name, self.builder_name, self.build_number, self.step_name)

@@ -203,7 +203,7 @@ class ProcessSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):

self.assertEqual(self.step_name, step_name)

self.assertIsNone(task_info[0])

- self.assertEqual({}, task_info[1])

+ self.assertEqual([], task_info[1])

task = WfSwarmingTask.Get(

self.master_name, self.builder_name, self.build_number, self.step_name)

@@ -234,7 +234,7 @@ class ProcessSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):

self.assertEqual(self.step_name, step_name)

self.assertEqual('abc_tests', task_info[0])

- self.assertEqual({}, task_info[1])

+ self.assertEqual([], task_info[1])

task = WfSwarmingTask.Get(

self.master_name, self.builder_name, self.build_number, self.step_name)