Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: appengine/findit/waterfall/analyze_build_failure_pipeline.py

Issue 2187763004: [Findit] Refactor Findit pipeline. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/analyze_build_failure_pipeline.py
diff --git a/appengine/findit/waterfall/analyze_build_failure_pipeline.py b/appengine/findit/waterfall/analyze_build_failure_pipeline.py
index b7916a785cfb48b3862bff8f4abc99cc339ce13b..d769bb7462ad37ab78ec21cc11825b181cfe324a 100644
--- a/appengine/findit/waterfall/analyze_build_failure_pipeline.py
+++ b/appengine/findit/waterfall/analyze_build_failure_pipeline.py
@@ -70,6 +70,8 @@ class AnalyzeBuildFailurePipeline(BasePipeline):
# The yield statements below return PipelineFutures, which allow subsequent
# pipelines to refer to previous output values.
# https://github.com/GoogleCloudPlatform/appengine-pipelines/wiki/Python
+
+ # Heuristic Approach.
failure_info = yield DetectFirstFailurePipeline(
master_name, builder_name, build_number)
change_logs = yield PullChangelogPipeline(failure_info)
@@ -78,11 +80,14 @@ class AnalyzeBuildFailurePipeline(BasePipeline):
heuristic_result = yield IdentifyCulpritPipeline(
failure_info, change_logs, deps_info, signals, build_completed)
+ # Try job Approach.
with pipeline.InOrder():
- # Triggers swarming tasks when test failure happens.
+ # Swarming rerun.
+ # Triggers swarming tasks when first time test failure happens.
+ # This pipeline will run before build completes.
yield TriggerSwarmingTasksPipeline(
master_name, builder_name, build_number, failure_info)
- # Checks if need a try job and starts one if yes.
+ # Checks if first time failures happen and starts a try job if yes.
yield StartTryJobOnDemandPipeline(
- failure_info, signals, build_completed, force_rerun_try_job,
- heuristic_result)
+ master_name, builder_name, build_number, failure_info,
+ signals, heuristic_result, build_completed, force_rerun_try_job)
« no previous file with comments | « appengine/findit/model/wf_swarming_task.py ('k') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698