Return unique_ptrs from base::ProcessMetrics.

Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865
Committed: https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec
Cr-Commit-Position: refs/heads/master@{#407851}

[Lei Zhang, 2016-07-23 10:06:08]

Description was changed from

==========
Return unique_ptrs from base::ProcessMetrics.
==========

to

==========
Return unique_ptrs from base::ProcessMetrics.

BUG=581865
==========

[Lei Zhang, 2016-07-23 10:06:32]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 10:06:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-23 10:08:56]

Description was changed from

==========
Return unique_ptrs from base::ProcessMetrics.

BUG=581865
==========

to

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs

BUG=581865
==========

[commit-bot: I haz the power, 2016-07-23 10:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 10:25:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-07-23 23:22:13]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 23:22:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 23:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 23:48:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[Lei Zhang, 2016-07-24 05:23:49]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-24 05:24:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-24 05:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-24 05:51:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Lei Zhang, 2016-07-24 05:58:56]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-24 05:59:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-25 17:24:57]

Description was changed from

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs

BUG=581865
==========

to

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU

BUG=581865
==========

[Lei Zhang, 2016-07-25 17:25:15]

Description was changed from

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU

BUG=581865
==========

to

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865
==========

[Lei Zhang, 2016-07-25 17:28:19]

thestig@chromium.org changed reviewers:
+ afakhry@chromium.org, dcheng@chromium.org, skuhne@chromium.org

[Lei Zhang, 2016-07-25 17:28:21]

dcheng: base/
afakhry: chrome/
skuhne: components/memory_pressure

https://codereview.chromium.org/2181493002/diff/80001/base/process/process_me...
File base/process/process_metrics_linux.cc (right):

https://codereview.chromium.org/2181493002/diff/80001/base/process/process_me...
base/process/process_metrics_linux.cc:169: return WrapUnique(new
ProcessMetrics(process));
dcheng: Any suggestions on how to better handle private ctors?

[afakhry, 2016-07-25 17:58:46]

afakhry@chromium.org changed reviewers:
+ nick@chromium.org

[afakhry, 2016-07-25 17:58:47]

LGTM.
+nick as the OWNER of the old task manager.

https://codereview.chromium.org/2181493002/diff/80001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager.cc (left):

https://codereview.chromium.org/2181493002/diff/80001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager.cc:621:
GetWinGDIHandles(GetResource(index)->GetProcess(),
You can now remove c/b/task_manager/os_resource_win.(cc|h).

[ncarter (slow), 2016-07-25 18:13:55]

lgtm

[Lei Zhang, 2016-07-25 18:25:47]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[Lei Zhang, 2016-07-25 18:26:12]

https://codereview.chromium.org/2181493002/diff/80001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager.cc (left):

https://codereview.chromium.org/2181493002/diff/80001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager.cc:621:
GetWinGDIHandles(GetResource(index)->GetProcess(),
On 2016/07/25 17:58:47, afakhry wrote:
> You can now remove c/b/task_manager/os_resource_win.(cc|h).

Done.

[commit-bot: I haz the power, 2016-07-25 18:26:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 20:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 20:06:50]

Dry run: This issue passed the CQ dry run.

[Mr4D (OOO till 08-26), 2016-07-25 20:49:44]

components/memory_pressure lgtm

[dcheng, 2016-07-26 05:21:39]

//base lgtm

https://codereview.chromium.org/2181493002/diff/100001/base/process/process_m...
File base/process/process_metrics_freebsd.cc (right):

https://codereview.chromium.org/2181493002/diff/100001/base/process/process_m...
base/process/process_metrics_freebsd.cc:27: return WrapUnique(new
ProcessMetrics(process));
Nit: base::MakeUnique while you're changing this? Similar comments elsewhere.

[Lei Zhang, 2016-07-26 05:53:03]

https://codereview.chromium.org/2181493002/diff/100001/base/process/process_m...
File base/process/process_metrics_freebsd.cc (right):

https://codereview.chromium.org/2181493002/diff/100001/base/process/process_m...
base/process/process_metrics_freebsd.cc:27: return WrapUnique(new
ProcessMetrics(process));
On 2016/07/26 05:21:38, dcheng wrote:
> Nit: base::MakeUnique while you're changing this? Similar comments elsewhere.

I guess you missed my comment. How do we deal with private ctors?

[dcheng, 2016-07-26 07:58:28]

On 2016/07/26 05:53:03, Lei Zhang wrote:
>
https://codereview.chromium.org/2181493002/diff/100001/base/process/process_m...
> File base/process/process_metrics_freebsd.cc (right):
> 
>
https://codereview.chromium.org/2181493002/diff/100001/base/process/process_m...
> base/process/process_metrics_freebsd.cc:27: return WrapUnique(new
> ProcessMetrics(process));
> On 2016/07/26 05:21:38, dcheng wrote:
> > Nit: base::MakeUnique while you're changing this? Similar comments
elsewhere.
> 
> I guess you missed my comment. How do we deal with private ctors?

Ah oops, sorry. Rietveld didn't expand it so I missed it.

WrapUnique() is the best way for now I guess =)

[Lei Zhang, 2016-07-26 17:29:57]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org, rockot@chromium.org

[Lei Zhang, 2016-07-26 17:29:58]

+dsinclair for components/tracing
+rockot for ipc/

[Ken Rockot(use gerrit already), 2016-07-26 17:30:43]

lgtm

[dsinclair, 2016-07-26 17:48:44]

base/trace_event and components/tracing lgtm

[Lei Zhang, 2016-07-26 17:53:08]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-07-26 17:53:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
afakhry@chromium.org, nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2181493002/#ps100001
(title: "remove os_resource_win.*")

[commit-bot: I haz the power, 2016-07-26 17:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:59:52]

Description was changed from

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865
==========

to

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865
==========

[commit-bot: I haz the power, 2016-07-26 17:59:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-26 18:03:25]

Description was changed from

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865
==========

to

==========
Return unique_ptrs from base::ProcessMetrics.

- Use more C++11
- Get rid of linked_ptrs
- IWYU
- Remove dead code in old task manager

BUG=581865

Committed: https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec
Cr-Commit-Position: refs/heads/master@{#407851}
==========

[commit-bot: I haz the power, 2016-07-26 18:03:27]

Patchset 6 (id:??) landed as
https://crrev.com/0df2bae8b6aba21a905ec7240c50fbe44ff361ec
Cr-Commit-Position: refs/heads/master@{#407851}