Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2716)

Unified Diff: chrome/browser/performance_monitor/process_metrics_history.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove os_resource_win.* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/process_metrics_history.cc
diff --git a/chrome/browser/performance_monitor/process_metrics_history.cc b/chrome/browser/performance_monitor/process_metrics_history.cc
index 2456aa95767b4aa28d8ab6ba62f64e009b4ddec1..c91282ffb41d88090e379d4c752531094a4770cb 100644
--- a/chrome/browser/performance_monitor/process_metrics_history.cc
+++ b/chrome/browser/performance_monitor/process_metrics_history.cc
@@ -36,9 +36,6 @@ ProcessMetricsHistory::ProcessMetricsHistory()
: last_update_sequence_(0), cpu_usage_(0.0), trace_trigger_handle_(-1) {
}
-ProcessMetricsHistory::ProcessMetricsHistory(
- const ProcessMetricsHistory& other) = default;
-
ProcessMetricsHistory::~ProcessMetricsHistory() {
}
@@ -50,12 +47,12 @@ void ProcessMetricsHistory::Initialize(
last_update_sequence_ = initial_update_sequence;
#if defined(OS_MACOSX)
- process_metrics_.reset(base::ProcessMetrics::CreateProcessMetrics(
+ process_metrics_ = base::ProcessMetrics::CreateProcessMetrics(
process_data_.handle,
- content::BrowserChildProcessHost::GetPortProvider()));
+ content::BrowserChildProcessHost::GetPortProvider());
#else
- process_metrics_.reset(
- base::ProcessMetrics::CreateProcessMetrics(process_data_.handle));
+ process_metrics_ =
+ base::ProcessMetrics::CreateProcessMetrics(process_data_.handle);
#endif
const char* trigger_name = NULL;

Powered by Google App Engine
This is Rietveld 408576698