components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc - Issue 2181493002: Return unique_ptrs from base::ProcessMetrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove os_resource_win.* Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process/process_metrics_freebsd.cc ('K') | « components/memory_pressure/direct_memory_pressure_calculator_linux.cc ('k') | components/memory_pressure/direct_memory_pressure_calculator_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc

diff --git a/components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc b/components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc

index 52c922c72b56bf95df396a01f5b7bfb5468ebd8c..490ffc7c7d5ca57bbca6a52028c12791f5381433 100644

--- a/components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc

+++ b/components/memory_pressure/direct_memory_pressure_calculator_linux_unittest.cc

@@ -4,14 +4,15 @@

#include "components/memory_pressure/direct_memory_pressure_calculator_linux.h"

+#include "base/process/process_metrics.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace memory_pressure {

namespace {

-static const int kKBperMB = 1024;

-static const int kTotalMemoryInMB = 4096;

+const int kKBperMB = 1024;

+const int kTotalMemoryInMB = 4096;

} // namespace

@@ -20,7 +21,7 @@ static const int kTotalMemoryInMB = 4096;

class TestDirectMemoryPressureCalculator

: public DirectMemoryPressureCalculator {

public:

- explicit TestDirectMemoryPressureCalculator()

+ TestDirectMemoryPressureCalculator()

: DirectMemoryPressureCalculator(20, 10) {

// The values passed to the MemoryPressureCalculator constructor are dummy

// values that are immediately overwritten by InferTresholds.