Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: base/process/process_metrics_openbsd.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove os_resource_win.* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/process/process_metrics_openbsd.cc
diff --git a/base/process/process_metrics_openbsd.cc b/base/process/process_metrics_openbsd.cc
index 3f76cc222d9345b532c87bc8346b79961b272b48..58033aef62e75110d27978a75e21fbe2f7affbdb 100644
--- a/base/process/process_metrics_openbsd.cc
+++ b/base/process/process_metrics_openbsd.cc
@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/macros.h"
#include "base/process/process_metrics.h"
#include <stddef.h>
@@ -10,11 +9,16 @@
#include <sys/param.h>
#include <sys/sysctl.h>
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/sys_info.h"
+
namespace base {
// static
-ProcessMetrics* ProcessMetrics::CreateProcessMetrics(ProcessHandle process) {
- return new ProcessMetrics(process);
+std::unique_ptr<ProcessMetrics> ProcessMetrics::CreateProcessMetrics(
+ ProcessHandle process) {
+ return WrapUnique(new ProcessMetrics(process));
}
size_t ProcessMetrics::GetPagefileUsage() const {
@@ -136,11 +140,9 @@ double ProcessMetrics::GetCPUUsage() {
ProcessMetrics::ProcessMetrics(ProcessHandle process)
: process_(process),
+ processor_count_(SysInfo::NumberOfProcessors()),
last_system_time_(0),
- last_cpu_(0) {
-
- processor_count_ = base::SysInfo::NumberOfProcessors();
-}
+ last_cpu_(0) {}
size_t GetSystemCommitCharge() {
int mib[] = { CTL_VM, VM_METER };

Powered by Google App Engine
This is Rietveld 408576698