Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: chrome/test/base/chrome_process_util.h

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove os_resource_win.* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/chrome_process_util.h
diff --git a/chrome/test/base/chrome_process_util.h b/chrome/test/base/chrome_process_util.h
index b666a76b29da33093f5b797639ecc2b2941bd91f..f89a1a80bfa04c50519ab3f8c4c7b09b7fa105ff 100644
--- a/chrome/test/base/chrome_process_util.h
+++ b/chrome/test/base/chrome_process_util.h
@@ -15,7 +15,7 @@
#include "base/process/process_metrics.h"
#include "build/build_config.h"
-typedef std::vector<base::ProcessId> ChromeProcessList;
+using ChromeProcessList = std::vector<base::ProcessId>;
// Returns a vector of PIDs of all chrome processes (main and renderers etc)
// based on |browser_pid|, the PID of the main browser process.
@@ -41,17 +41,11 @@ class ChromeTestProcessMetrics {
size_t GetWorkingSetSize();
- size_t GetPeakPagefileUsage() {
- return process_metrics_->GetPeakPagefileUsage();
- }
+ size_t GetPeakPagefileUsage();
- size_t GetPeakWorkingSetSize() {
- return process_metrics_->GetPeakWorkingSetSize();
- }
+ size_t GetPeakWorkingSetSize();
- bool GetIOCounters(base::IoCounters* io_counters) {
- return process_metrics_->GetIOCounters(io_counters);
- }
+ bool GetIOCounters(base::IoCounters* io_counters);
base::ProcessHandle process_handle_;
@@ -82,11 +76,11 @@ struct MacChromeProcessInfo {
int vsz_in_kb;
};
-typedef std::vector<MacChromeProcessInfo> MacChromeProcessInfoList;
+using MacChromeProcessInfoList = std::vector<MacChromeProcessInfo>;
// Any ProcessId that info can't be found for will be left out.
MacChromeProcessInfoList GetRunningMacProcessInfo(
- const ChromeProcessList& process_list);
+ const ChromeProcessList& process_list);
#endif // defined(OS_MACOSX)

Powered by Google App Engine
This is Rietveld 408576698