chrome/browser/memory_details_mac.cc - Issue 2181493002: Return unique_ptrs from base::ProcessMetrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory_details_mac.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove os_resource_win.* Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/memory_details_mac.cc

diff --git a/chrome/browser/memory_details_mac.cc b/chrome/browser/memory_details_mac.cc

index 08ca920bff222db350dc793d12ae1582ab0d4498..40fb326d608e4664594fc66d90d40634851dd9d5 100644

--- a/chrome/browser/memory_details_mac.cc

+++ b/chrome/browser/memory_details_mac.cc

@@ -57,9 +57,9 @@ void CollectProcessDataForChromeProcess(

}

- std::unique_ptr<base::ProcessMetrics> metrics;

- metrics.reset(base::ProcessMetrics::CreateProcessMetrics(

- pid, content::BrowserChildProcessHost::GetPortProvider()));

+ std::unique_ptr<base::ProcessMetrics> metrics =

+ base::ProcessMetrics::CreateProcessMetrics(

+ pid, content::BrowserChildProcessHost::GetPortProvider());

metrics->GetCommittedAndWorkingSetKBytes(&info.committed, &info.working_set);

processes->push_back(info);