base/process/process_metrics.cc - Issue 2181493002: Return unique_ptrs from base::ProcessMetrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/process_metrics.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove os_resource_win.* Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process/process_metrics.cc

diff --git a/base/process/process_metrics.cc b/base/process/process_metrics.cc

index 0b387264315c0790a201007fa4b744777157d245..cc6532c8dca15c233044c24c4f5e0e3557ef99db 100644

--- a/base/process/process_metrics.cc

+++ b/base/process/process_metrics.cc

@@ -46,7 +46,7 @@ std::unique_ptr<Value> SystemMetrics::ToValue() const {

return std::move(res);

}

-ProcessMetrics* ProcessMetrics::CreateCurrentProcessMetrics() {

+std::unique_ptr<ProcessMetrics> ProcessMetrics::CreateCurrentProcessMetrics() {

#if !defined(OS_MACOSX) || defined(OS_IOS)

return CreateProcessMetrics(base::GetCurrentProcessHandle());

#else