Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: chrome/browser/task_management/sampling/task_group_sampler.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove os_resource_win.* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/sampling/task_group_sampler.cc
diff --git a/chrome/browser/task_management/sampling/task_group_sampler.cc b/chrome/browser/task_management/sampling/task_group_sampler.cc
index ca1c36ec9b1918f2e9f3c9fc37bf2bf9928e01c1..435bc70cab742729b513d616e5f23534711df2cc 100644
--- a/chrome/browser/task_management/sampling/task_group_sampler.cc
+++ b/chrome/browser/task_management/sampling/task_group_sampler.cc
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/callback.h"
+#include "base/process/process_metrics.h"
#include "build/build_config.h"
#include "chrome/browser/task_management/task_manager_observer.h"
#include "content/public/browser/browser_child_process_host.h"
@@ -17,7 +18,8 @@ namespace task_management {
namespace {
-base::ProcessMetrics* CreateProcessMetrics(base::ProcessHandle handle) {
+std::unique_ptr<base::ProcessMetrics> CreateProcessMetrics(
+ base::ProcessHandle handle) {
#if !defined(OS_MACOSX)
return base::ProcessMetrics::CreateProcessMetrics(handle);
#else

Powered by Google App Engine
This is Rietveld 408576698