Return unique_ptrs from base::ProcessMetrics.

base/process/process_metrics_freebsd.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/process_metrics.h"
 
 #include <stddef.h>
 #include <sys/sysctl.h>
 #include <sys/user.h>
 #include <unistd.h>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/sys_info.h"
 
 namespace base {
 
 ProcessMetrics::ProcessMetrics(ProcessHandle process)
     : process_(process),
+      processor_count_(SysInfo::NumberOfProcessors()),
       last_system_time_(0),
-      last_cpu_(0) {
-  processor_count_ = base::SysInfo::NumberOfProcessors();
-}
+      last_cpu_(0) {}
 
 // static
-ProcessMetrics* ProcessMetrics::CreateProcessMetrics(ProcessHandle process) {
-  return new ProcessMetrics(process);
+std::unique_ptr<ProcessMetrics> ProcessMetrics::CreateProcessMetrics(
+    ProcessHandle process) {
+  return WrapUnique(new ProcessMetrics(process));

[dcheng, 2016/07/26 05:21:38]

Nit: base::MakeUnique while you're changing this? Similar comments elsewhere.

[Lei Zhang, 2016/07/26 05:53:02]

I guess you missed my comment. How do we deal with private ctors?

 }
 
 size_t ProcessMetrics::GetPagefileUsage() const {
   struct kinfo_proc info;
   int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_PID, process_ };
   size_t length = sizeof(info);
 
   if (sysctl(mib, arraysize(mib), &info, &length, NULL, 0) < 0)
     return 0;
 
@@ skipping 78 matching lines @@
       NULL, 0) < 0) {
     return 0;
   }
 
   pagesize = getpagesize();
 
   return mem_total - (mem_free*pagesize) - (mem_inactive*pagesize);
 }
 
 }  // namespace base