Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: components/tracing/common/process_metrics_memory_dump_provider.cc

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove os_resource_win.* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/common/process_metrics_memory_dump_provider.cc
diff --git a/components/tracing/common/process_metrics_memory_dump_provider.cc b/components/tracing/common/process_metrics_memory_dump_provider.cc
index 100eacf9fad3bbdf838c06bd3cd57aecc3418c90..d2c00c347f0db3f7f9b13286e2af3edc4ac089b3 100644
--- a/components/tracing/common/process_metrics_memory_dump_provider.cc
+++ b/components/tracing/common/process_metrics_memory_dump_provider.cc
@@ -160,16 +160,14 @@ uint32_t ReadLinuxProcSmapsFile(FILE* smaps_file,
std::unique_ptr<base::ProcessMetrics> CreateProcessMetrics(
base::ProcessId process) {
if (process == base::kNullProcessId)
- return base::WrapUnique(
- base::ProcessMetrics::CreateCurrentProcessMetrics());
+ return base::ProcessMetrics::CreateCurrentProcessMetrics();
#if defined(OS_LINUX) || defined(OS_ANDROID)
// Just pass ProcessId instead of handle since they are the same in linux and
// android.
- return base::WrapUnique(base::ProcessMetrics::CreateProcessMetrics(process));
+ return base::ProcessMetrics::CreateProcessMetrics(process);
#else
// Creating process metrics for child processes in mac or windows requires
- // additional information like ProcessHandle or port provider. This is a non
- // needed use case.
+ // additional information like ProcessHandle or port provider.
NOTREACHED();
return std::unique_ptr<base::ProcessMetrics>();
#endif // defined(OS_LINUX) || defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698