Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4794)

Unified Diff: chrome/browser/performance_monitor/process_metrics_history.h

Issue 2181493002: Return unique_ptrs from base::ProcessMetrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove os_resource_win.* Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/process_metrics_history.h
diff --git a/chrome/browser/performance_monitor/process_metrics_history.h b/chrome/browser/performance_monitor/process_metrics_history.h
index 99c25ddfbbfffc18121b100282b4065e6e48466c..fb633bb353186b486a3a70b4891a025ecb047940 100644
--- a/chrome/browser/performance_monitor/process_metrics_history.h
+++ b/chrome/browser/performance_monitor/process_metrics_history.h
@@ -5,8 +5,9 @@
#ifndef CHROME_BROWSER_PERFORMANCE_MONITOR_PROCESS_METRICS_HISTORY_H_
#define CHROME_BROWSER_PERFORMANCE_MONITOR_PROCESS_METRICS_HISTORY_H_
+#include <memory>
+
#include "base/macros.h"
-#include "base/memory/linked_ptr.h"
#include "base/process/process_handle.h"
#include "content/public/browser/background_tracing_manager.h"
#include "content/public/browser/child_process_data.h"
@@ -38,7 +39,7 @@ struct ProcessMetricsMetadata {
class ProcessMetricsHistory {
public:
ProcessMetricsHistory();
- ProcessMetricsHistory(const ProcessMetricsHistory& other);
+ ProcessMetricsHistory(const ProcessMetricsHistory& other) = delete;
~ProcessMetricsHistory();
// Configure this to monitor a specific process.
@@ -63,7 +64,7 @@ class ProcessMetricsHistory {
// May not be fully populated. e.g. no |id| and no |name| for browser and
// renderer processes.
ProcessMetricsMetadata process_data_;
- linked_ptr<base::ProcessMetrics> process_metrics_;
+ std::unique_ptr<base::ProcessMetrics> process_metrics_;
int last_update_sequence_;
double cpu_usage_;

Powered by Google App Engine
This is Rietveld 408576698