Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not override data getter in heap snapshot grid nodes This complicates things significantly and also leads to repeated computations of the data object for each cell. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170042

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixed tess #

Patch Set 3 : Fixed tests #

Patch Set 4 : Removed unused parameter from findRow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -297 lines) Patch
M LayoutTests/inspector/profiler/heap-snapshot-comparison-dom-groups-change.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html View 1 2 3 3 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-comparison-show-all.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-comparison-show-next.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-search.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-show-all.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-show-next.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-show-ranges.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-test.js View 1 2 3 5 chunks +22 lines, -41 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshot.js View 4 chunks +5 lines, -8 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshotDataGrids.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/HeapSnapshotGridNodes.js View 21 chunks +162 lines, -170 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshotProxy.js View 4 chunks +4 lines, -26 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshotView.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 9 months ago (2014-03-25 16:07:20 UTC) #1
loislo
https://codereview.chromium.org/211273005/diff/1/Source/devtools/front_end/HeapSnapshotGridNodes.js File Source/devtools/front_end/HeapSnapshotGridNodes.js (right): https://codereview.chromium.org/211273005/diff/1/Source/devtools/front_end/HeapSnapshotGridNodes.js#newcode492 Source/devtools/front_end/HeapSnapshotGridNodes.js:492: this._retainedSize = node.retainedSize; Looks like we don't need these ...
6 years, 9 months ago (2014-03-26 08:36:04 UTC) #2
yurys
https://codereview.chromium.org/211273005/diff/1/Source/devtools/front_end/HeapSnapshotGridNodes.js File Source/devtools/front_end/HeapSnapshotGridNodes.js (right): https://codereview.chromium.org/211273005/diff/1/Source/devtools/front_end/HeapSnapshotGridNodes.js#newcode492 Source/devtools/front_end/HeapSnapshotGridNodes.js:492: this._retainedSize = node.retainedSize; On 2014/03/26 08:36:04, loislo wrote: > ...
6 years, 9 months ago (2014-03-26 09:25:08 UTC) #3
loislo
On 2014/03/26 09:25:08, yurys wrote: > https://codereview.chromium.org/211273005/diff/1/Source/devtools/front_end/HeapSnapshotGridNodes.js > File Source/devtools/front_end/HeapSnapshotGridNodes.js (right): > > https://codereview.chromium.org/211273005/diff/1/Source/devtools/front_end/HeapSnapshotGridNodes.js#newcode492 > ...
6 years, 9 months ago (2014-03-26 09:46:35 UTC) #4
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-26 09:47:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/211273005/140001
6 years, 9 months ago (2014-03-26 09:47:22 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 10:50:24 UTC) #7
Message was sent while issue was closed. 
Change committed as 170042

Powered by Google App Engine
This is Rietveld 408576698