LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html - Issue 211273005: Do not override data getter in heap snapshot grid nodes

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-comparison-show-next.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="heap-snapshot-test.js"></script>	4 <script src="heap-snapshot-test.js"></script>

5 <script>	5 <script>

6	6

7 function test()	7 function test()

8 {	8 {

9 var instanceCount = 24;	9 var instanceCount = 24;

10 function createHeapSnapshotA()	10 function createHeapSnapshotA()

(...skipping 20 matching lines...) Expand all Loading...
31	31

32 var columns;	32 var columns;

33 function step2()	33 function step2()

34 {	34 {

35 columns = InspectorTest.viewColumns();	35 columns = InspectorTest.viewColumns();

36 InspectorTest.clickColumn(columns[0], step3);	36 InspectorTest.clickColumn(columns[0], step3);

37 }	37 }

38	38

39 function step3()	39 function step3()

40 {	40 {

41 var row = InspectorTest.findRow("object", "B");	41 var row = InspectorTest.findRow("B");

42 InspectorTest.assertEquals(true, !!row, "\"B\" row");	42 InspectorTest.assertEquals(true, !!row, "\"B\" row");

43 InspectorTest.expandRow(row, showNext);	43 InspectorTest.expandRow(row, showNext);

44 function showNext(row)	44 function showNext(row)

45 {	45 {

46 var buttonsNode = InspectorTest.findButtonsNode(row);	46 var buttonsNode = InspectorTest.findButtonsNode(row);

47 InspectorTest.assertEquals(true, !!buttonsNode, "no buttons node found!");	47 InspectorTest.assertEquals(true, !!buttonsNode, "no buttons node found!");

48 InspectorTest.clickShowMoreButton("showAll", buttonsNode, st ep4);	48 InspectorTest.clickShowMoreButton("showAll", buttonsNode, st ep4);

49 }	49 }

50 }	50 }

51	51

52 function step4()	52 function step4()

53 {	53 {

54 var row = InspectorTest.findRow("object", "B");	54 var row = InspectorTest.findRow("B");

55 InspectorTest.assertEquals(true, !!row, "\"B\" row");	55 InspectorTest.assertEquals(true, !!row, "\"B\" row");

56 function deletedNodeMatcher(data)	56 function deletedNodeMatcher(data)

57 {	57 {

58 return data.removedCount && data.object.value.charAt(0) === "B";	58 return data._isDeletedNode && data._name.charAt(0) === "B";

59 }	59 }

60 var bInstanceRow = InspectorTest.findRow2(deletedNodeMatcher, ro w);	60 var bInstanceRow = InspectorTest.findMatchingRow(deletedNodeMatc her, row);

61 InspectorTest.assertEquals(true, !!bInstanceRow, "\"B\" instance row");	61 InspectorTest.assertEquals(true, !!bInstanceRow, "\"B\" instance row");

62 var buttonsNode = InspectorTest.findButtonsNode(row, bInstanceRo w);	62 var buttonsNode = InspectorTest.findButtonsNode(row, bInstanceRo w);

63 InspectorTest.assertEquals(false, !!buttonsNode, "buttons node f ound!");	63 InspectorTest.assertEquals(false, !!buttonsNode, "buttons node f ound!");

64 step5();	64 step5();

65 }	65 }

66	66

67 var nodeCount;	67 var nodeCount;

68 function step5()	68 function step5()

69 {	69 {

70 nodeCount = InspectorTest.columnContents(columns[0]).length;	70 nodeCount = InspectorTest.columnContents(columns[0]).length;

(...skipping 18 matching lines...) Expand all Loading...
89	89

90 </script>	90 </script>

91 </head>	91 </head>

92 <body onload="runTest()">	92 <body onload="runTest()">

93 <p>	93 <p>

94 Tests Comparison view of detailed heap snapshots.	94 Tests Comparison view of detailed heap snapshots.

95 Shown node count must be preserved after sorting.	95 Shown node count must be preserved after sorting.

96 </p>	96 </p>

97 </body>	97 </body>

98 </html>	98 </html>

OLD	NEW