Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-comparison-show-next.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-comparison-show-all.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="heap-snapshot-test.js"></script> 4 <script src="heap-snapshot-test.js"></script>
5 <script> 5 <script>
6 6
7 function test() 7 function test()
8 { 8 {
9 var instanceCount = 24; 9 var instanceCount = 24;
10 function createHeapSnapshotA() 10 function createHeapSnapshotA()
(...skipping 13 matching lines...) Expand all
24 InspectorTest.takeAndOpenSnapshot(createHeapSnapshotB, step1); 24 InspectorTest.takeAndOpenSnapshot(createHeapSnapshotB, step1);
25 } 25 }
26 26
27 function step1() 27 function step1()
28 { 28 {
29 InspectorTest.switchToView("Comparison", step2); 29 InspectorTest.switchToView("Comparison", step2);
30 } 30 }
31 31
32 function step2() 32 function step2()
33 { 33 {
34 var row = InspectorTest.findRow("object", "A"); 34 var row = InspectorTest.findRow("A");
35 InspectorTest.assertEquals(true, !!row, "\"A\" row"); 35 InspectorTest.assertEquals(true, !!row, "\"A\" row");
36 InspectorTest.expandRow(row, step3); 36 InspectorTest.expandRow(row, step3);
37 } 37 }
38 38
39 function step3(row) 39 function step3(row)
40 { 40 {
41 var expectedRowCountA = parseInt(row.data["addedCount"]); 41 var expectedRowCountA = parseInt(row.data["addedCount"]);
42 var rowsShown = InspectorTest.countDataRows(row, function(node) { return node.data.addedCount; }); 42 var rowsShown = InspectorTest.countDataRows(row, function(node) { return node.data.addedCount; });
43 InspectorTest.assertEquals(true, rowsShown <= expectedRowCountA, "shown more instances than created: " + rowsShown + " > " + expectedRowCountA); 43 InspectorTest.assertEquals(true, rowsShown <= expectedRowCountA, "shown more instances than created: " + rowsShown + " > " + expectedRowCountA);
44 if (rowsShown < expectedRowCountA) { 44 if (rowsShown < expectedRowCountA) {
(...skipping 25 matching lines...) Expand all
70 70
71 </script> 71 </script>
72 </head> 72 </head>
73 <body onload="runTest()"> 73 <body onload="runTest()">
74 <p> 74 <p>
75 Tests Comparison view of detailed heap snapshots. 75 Tests Comparison view of detailed heap snapshots.
76 Repeated clicks on &quot;Show Next&quot; button must show all nodes. 76 Repeated clicks on &quot;Show Next&quot; button must show all nodes.
77 </p> 77 </p>
78 </body> 78 </body>
79 </html> 79 </html>
OLDNEW
« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-comparison-show-all.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698