Source/devtools/front_end/HeapSnapshotDataGrids.js - Issue 211273005: Do not override data getter in heap snapshot grid nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/HeapSnapshotDataGrids.js

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/HeapSnapshotDataGrids.js

diff --git a/Source/devtools/front_end/HeapSnapshotDataGrids.js b/Source/devtools/front_end/HeapSnapshotDataGrids.js

index bafacce35c63a30e82a061780b95e6b351719879..3789abb805bde8bc3def8a1fadf4ad1434107a00 100644

--- a/Source/devtools/front_end/HeapSnapshotDataGrids.js

+++ b/Source/devtools/front_end/HeapSnapshotDataGrids.js

@@ -618,7 +618,7 @@ WebInspector.HeapSnapshotContainmentDataGrid.prototype = {

this.snapshot = snapshot;

var node = { nodeIndex: nodeIndex || snapshot.rootNodeIndex };

var fakeEdge = { node: node };

- this.setRootNode(new WebInspector.HeapSnapshotObjectNode(this, false, fakeEdge, null));

+ this.setRootNode(new WebInspector.HeapSnapshotObjectNode(this, snapshot, fakeEdge, null));

this.rootNode().sort();

« no previous file with comments | « Source/devtools/front_end/HeapSnapshot.js ('k') | Source/devtools/front_end/HeapSnapshotGridNodes.js » ('j') | no next file with comments »