LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html - Issue 211273005: Do not override data getter in heap snapshot grid nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html b/LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html

index 3ef4038302455a6cb25ac908702d70f8ca271891..ada454478663a4909a4605cf4f193717eaeb90db 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html

+++ b/LayoutTests/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html

@@ -24,7 +24,7 @@ function test()

function step2()

{

- var row = InspectorTest.findRow("object", "B");

+ var row = InspectorTest.findRow("B");

InspectorTest.assertEquals(true, !!row, "\"B\" row");

InspectorTest.expandRow(row, expandB);

function expandB()

@@ -44,7 +44,7 @@ function test()

function step4()

{

- var row = InspectorTest.findRow("object", "B");

+ var row = InspectorTest.findRow("B");

InspectorTest.assertEquals(true, !!row, "\"B\" row");

var bInstanceRow = row.children[0];

InspectorTest.assertEquals(true, !!bInstanceRow, "\"B\" instance row");

@@ -53,9 +53,9 @@ function test()

{

function propertyMatcher(data)

{

- return data.name === "a" && data.value.charAt(0) === "A";

+ return data._referenceName === "a" && data._name.charAt(0) === "A";

}

- var aRow = InspectorTest.findRow("object", propertyMatcher, row);

+ var aRow = InspectorTest.findMatchingRow(propertyMatcher, row);

InspectorTest.assertEquals(true, !!aRow, "\"a: A\" row");

InspectorTest.expandRow(aRow, step5);

}