LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html - Issue 211273005: Do not override data getter in heap snapshot grid nodes

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="heap-snapshot-test.js"></script>	4 <script src="heap-snapshot-test.js"></script>

5 <script>	5 <script>

6	6

7 function test()	7 function test()

8 {	8 {

9 var instanceCount = 10;	9 var instanceCount = 10;

10 function createHeapSnapshot()	10 function createHeapSnapshot()

(...skipping 10 matching lines...) Expand all Loading...
21 {	21 {

22 InspectorTest.switchToView("Summary", step1a);	22 InspectorTest.switchToView("Summary", step1a);

23 }	23 }

24	24

25 var columns;	25 var columns;

26 var currentColumn;	26 var currentColumn;

27 var currentColumnOrder;	27 var currentColumnOrder;

28	28

29 function step1a()	29 function step1a()

30 {	30 {

31 var row = InspectorTest.findRow("object", "B");	31 var row = InspectorTest.findRow("B");

32 InspectorTest.assertEquals(true, !!row, "\"B\" row");	32 InspectorTest.assertEquals(true, !!row, "\"B\" row");

33 InspectorTest.expandRow(row, step2);	33 InspectorTest.expandRow(row, step2);

34 }	34 }

35	35

36 function step2(row)	36 function step2(row)

37 {	37 {

38 columns = InspectorTest.viewColumns();	38 columns = InspectorTest.viewColumns();

39 currentColumn = 0;	39 currentColumn = 0;

40 currentColumnOrder = false;	40 currentColumnOrder = false;

41 step3();	41 step3();

42 }	42 }

43	43

44 function step3()	44 function step3()

45 {	45 {

46 if (currentColumn >= columns.length) {	46 if (currentColumn >= columns.length) {

47 setTimeout(next, 0);	47 setTimeout(next, 0);

48 return;	48 return;

49 }	49 }

50	50

51 InspectorTest.clickColumn(columns[currentColumn], step4);	51 InspectorTest.clickColumn(columns[currentColumn], step4);

52 }	52 }

53	53

54 function step4(newColumnState)	54 function step4(newColumnState)

55 {	55 {

56 columns[currentColumn] = newColumnState;	56 columns[currentColumn] = newColumnState;

57 var columnName = columns[currentColumn].identifier;	57 var columnName = columns[currentColumn].identifier;

58 var row = InspectorTest.findRow("object", "B");	58 var row = InspectorTest.findRow("B");

59 InspectorTest.assertEquals(true, !!row, "\"B\" row");	59 InspectorTest.assertEquals(true, !!row, "\"B\" row");

60 var contents = row.children.map(function(obj) { return JSON.stri ngify(obj.data[columnName]); });	60 var contents = row.children.map(function(obj) { return obj.eleme nt.children[currentColumn].textContent; });

61 InspectorTest.assertEquals(instanceCount, contents.length, "colu mn contents");	61 InspectorTest.assertEquals(instanceCount, contents.length, "colu mn contents");

62 var sortTypes = { object: "text", distance: "number", count: "nu mber", shallowSize: "size", retainedSize: "size" };	62 var sortTypes = { object: "text", distance: "number", count: "nu mber", shallowSize: "size", retainedSize: "size" };

63 InspectorTest.assertEquals(true, !!sortTypes[columns[currentColu mn].identifier], "sort by identifier");	63 InspectorTest.assertEquals(true, !!sortTypes[columns[currentColu mn].identifier], "sort by identifier");

64 InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[cur rentColumn].identifier], columns[currentColumn].sort);	64 InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[cur rentColumn].identifier], columns[currentColumn].sort);

65	65

66 if (!currentColumnOrder)	66 if (!currentColumnOrder)

67 currentColumnOrder = true;	67 currentColumnOrder = true;

68 else {	68 else {

69 currentColumnOrder = false;	69 currentColumnOrder = false;

70 ++currentColumn;	70 ++currentColumn;

71 }	71 }

72 step3();	72 step3();

73 }	73 }

74 }	74 }

75 ]);	75 ]);

76 }	76 }

77	77

78 </script>	78 </script>

79 </head>	79 </head>

80 <body onload="runTest()">	80 <body onload="runTest()">

81 <p>	81 <p>

82 Tests sorting in Summary view of detailed heap snapshots.	82 Tests sorting in Summary view of detailed heap snapshots.

83 </p>	83 </p>

84 </body>	84 </body>

85 </html>	85 </html>

OLD	NEW