Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html
diff --git a/LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html b/LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html
index eecc347cb2304723ca79f4c6874b658ec211f859..f443c1349a15235137bbd5048cce4fdc558fdd4a 100644
--- a/LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html
+++ b/LayoutTests/inspector/profiler/heap-snapshot-summary-retainers.html
@@ -24,7 +24,7 @@ function test()
function step2()
{
- var row = InspectorTest.findRow("object", "A");
+ var row = InspectorTest.findRow("A");
InspectorTest.assertEquals(true, !!row, "\"A\" row");
InspectorTest.expandRow(row, step3);
}
@@ -89,7 +89,7 @@ function test()
function step2()
{
- var row = InspectorTest.findRow("object", "L3");
+ var row = InspectorTest.findRow("L3");
InspectorTest.assertEquals(true, !!row, "\"L3\" row");
InspectorTest.expandRow(row, step3);
}
@@ -113,12 +113,12 @@ function test()
var l3 = retainersRoot;
InspectorTest.assertEquals(1, l3.children.length, "One retainer of L3");
var l2 = l3.children[0];
- InspectorTest.assertEquals("y", l2.data.object.name);
+ InspectorTest.assertEquals("y", l2._referenceName);
InspectorTest.assertEquals(1, l2.children.length, "One retainer of L2");
var l1 = l2.children[0];
- InspectorTest.assertEquals("x", l1.data.object.name);
+ InspectorTest.assertEquals("x", l1._referenceName);
InspectorTest.assertEquals(2, l1.children.length, "Two retainers of L1");
- var l1retainers = [l1.children[0].data.object.name, l1.children[1].data.object.name];
+ var l1retainers = [l1.children[0]._referenceName, l1.children[1]._referenceName];
l1retainers.sort();
InspectorTest.assertEquals("l1a", l1retainers[0]);
InspectorTest.assertEquals("l1b", l1retainers[1]);
@@ -168,7 +168,7 @@ function test()
function step2()
{
- var row = InspectorTest.findRow("object", "Tail");
+ var row = InspectorTest.findRow("Tail");
InspectorTest.assertEquals(true, !!row, "\"Tail\" row");
InspectorTest.expandRow(row, step3);
}

Powered by Google App Engine
This is Rietveld 408576698