Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
diff --git a/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html b/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
index f6d88ca07f24763cb43ad7d66cab653aaf7a78c3..4e44f021812a12ad73fae2d145de6db4571e8271 100644
--- a/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
+++ b/LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
@@ -31,7 +31,7 @@ function test()
function step2()
{
- var row = InspectorTest.findRow("object", "B");
+ var row = InspectorTest.findRow("B");
InspectorTest.assertEquals(true, !!row, "\"B\" row");
InspectorTest.expandRow(row, expandB);
function expandB()
@@ -51,18 +51,18 @@ function test()
function step5()
{
- var row = InspectorTest.findRow("object", "B");
+ var row = InspectorTest.findRow("B");
InspectorTest.assertEquals(true, !!row, "\"B\" row");
var bInstanceRow = row.children[0];
InspectorTest.assertEquals(true, !!bInstanceRow, "\"B\" instance row");
InspectorTest.expandRow(bInstanceRow, expandA);
function expandA(row)
{
- function propertyMatcher(data)
+ function propertyMatcher(node)
{
- return data.name === "a" && data.value.charAt(0) === "A";
+ return node._referenceName === "a" && node._name.charAt(0) === "A";
}
- var aRow = InspectorTest.findRow("object", propertyMatcher, row);
+ var aRow = InspectorTest.findMatchingRow(propertyMatcher, row);
InspectorTest.assertEquals(true, !!aRow, "\"a: A\" row");
InspectorTest.expandRow(aRow, step6);
}
@@ -70,22 +70,22 @@ function test()
function step6()
{
- var row = InspectorTest.findRow("object", "B");
+ var row = InspectorTest.findRow("B");
InspectorTest.assertEquals(true, !!row, "\"B\" row");
function deletedNodeMatcher(data)
{
- return data.removedCount && data.object.value.charAt(0) === "B";
+ return data._isDeletedNode && data._name.charAt(0) === "B";
}
- var bInstanceRow = InspectorTest.findRow2(deletedNodeMatcher, row);
+ var bInstanceRow = InspectorTest.findMatchingRow(deletedNodeMatcher, row);
InspectorTest.assertEquals(true, !!bInstanceRow, "\"B\" instance row");
InspectorTest.expandRow(bInstanceRow, expandA);
function expandA(row)
{
function propertyMatcher(data)
{
- return data.name === "a" && data.value.charAt(0) === "A";
+ return data._referenceName === "a" && data._name.charAt(0) === "A";
}
- var aRow = InspectorTest.findRow("object", propertyMatcher, row);
+ var aRow = InspectorTest.findMatchingRow(propertyMatcher, row);
InspectorTest.assertEquals(true, !!aRow, "\"a: A\" row");
InspectorTest.expandRow(aRow, step7);
}

Powered by Google App Engine
This is Rietveld 408576698