LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html - Issue 211273005: Do not override data getter in heap snapshot grid nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html b/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

index 0a25559238f555992f1e2f901281be8f388935c5..7babde87bd619269eb323ec3a7ce0d68ed1166b6 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

+++ b/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

@@ -28,7 +28,7 @@ function test()

function step1a()

{

- var row = InspectorTest.findRow("object", "B");

+ var row = InspectorTest.findRow("B");

InspectorTest.assertEquals(true, !!row, "\"B\" row");

InspectorTest.expandRow(row, step2);

}

@@ -55,9 +55,9 @@ function test()

{

columns[currentColumn] = newColumnState;

var columnName = columns[currentColumn].identifier;

- var row = InspectorTest.findRow("object", "B");

+ var row = InspectorTest.findRow("B");

InspectorTest.assertEquals(true, !!row, "\"B\" row");

- var contents = row.children.map(function(obj) { return JSON.stringify(obj.data[columnName]); });

+ var contents = row.children.map(function(obj) { return obj.element.children[currentColumn].textContent; });

InspectorTest.assertEquals(instanceCount, contents.length, "column contents");

var sortTypes = { object: "text", distance: "number", count: "number", shallowSize: "size", retainedSize: "size" };

InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].identifier], "sort by identifier");