LayoutTests/inspector/profiler/heap-snapshot-comparison-show-all.html - Issue 211273005: Do not override data getter in heap snapshot grid nodes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-comparison-show-all.html

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-comparison-show-next.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="heap-snapshot-test.js"></script>	4 <script src="heap-snapshot-test.js"></script>

5 <script>	5 <script>

6	6

7 function test()	7 function test()

8 {	8 {

9 var instanceCount = 24;	9 var instanceCount = 24;

10 var firstId = 100;	10 var firstId = 100;

(...skipping 14 matching lines...) Expand all Loading...
25 InspectorTest.takeAndOpenSnapshot(createHeapSnapshotB, step1);	25 InspectorTest.takeAndOpenSnapshot(createHeapSnapshotB, step1);

26 }	26 }

27	27

28 function step1()	28 function step1()

29 {	29 {

30 InspectorTest.switchToView("Comparison", step2);	30 InspectorTest.switchToView("Comparison", step2);

31 }	31 }

32	32

33 function step2()	33 function step2()

34 {	34 {

35 var row = InspectorTest.findRow("object", "A");	35 var row = InspectorTest.findRow("A");

36 InspectorTest.assertEquals(true, !!row, "\"A\" row");	36 InspectorTest.assertEquals(true, !!row, "\"A\" row");

37 InspectorTest.expandRow(row, step3);	37 InspectorTest.expandRow(row, step3);

38 }	38 }

39	39

40 var countA;	40 var countA;

41 var countB;	41 var countB;

42 function step3(row)	42 function step3(row)

43 {	43 {

44 countA = row._addedCount;	44 countA = row._addedCount;

45 InspectorTest.assertEquals(true, countA > 0, "countA > 0");	45 InspectorTest.assertEquals(true, countA > 0, "countA > 0");

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77	77

78 </script>	78 </script>

79 </head>	79 </head>

80 <body onload="runTest()">	80 <body onload="runTest()">

81 <p>	81 <p>

82 Tests Comparison view of detailed heap snapshots.	82 Tests Comparison view of detailed heap snapshots.

83 The "Show All" button must show all nodes.	83 The "Show All" button must show all nodes.

84 </p>	84 </p>

85 </body>	85 </body>

86 </html>	86 </html>

OLD	NEW