Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: Source/devtools/front_end/HeapSnapshotView.js

Issue 211273005: Do not override data getter in heap snapshot grid nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unused parameter from findRow Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotProxy.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/HeapSnapshotView.js
diff --git a/Source/devtools/front_end/HeapSnapshotView.js b/Source/devtools/front_end/HeapSnapshotView.js
index dabc32e63cbefd0daf5b83215f3f5831e41ff44b..859faaedae709f9a313a63d09110d7de8375e3a0 100644
--- a/Source/devtools/front_end/HeapSnapshotView.js
+++ b/Source/devtools/front_end/HeapSnapshotView.js
@@ -778,10 +778,14 @@ WebInspector.HeapSnapshotView.prototype = {
ConsoleAgent.addInspectedHeapObject(selectedNode.snapshotNodeId);
},
+ /**
+ * @param {?WebInspector.HeapSnapshotGridNode} nodeItem
+ */
_setRetainmentDataGridSource: function(nodeItem)
{
- if (nodeItem && nodeItem.snapshotNodeIndex)
- this._retainmentDataGrid.setDataSource(nodeItem.isDeletedNode ? nodeItem.dataGrid.baseSnapshot : nodeItem.dataGrid.snapshot, nodeItem.snapshotNodeIndex);
+ var dataSource = nodeItem && nodeItem.retainersDataSource();
+ if (dataSource)
+ this._retainmentDataGrid.setDataSource(dataSource.snapshot, dataSource.snapshotNodeIndex);
else
this._retainmentDataGrid.reset();
},
« no previous file with comments | « Source/devtools/front_end/HeapSnapshotProxy.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698