Move static GL binding initialization to //ui/gl/init.

Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialization is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's own method to improve
readability.

The PRESUBMIT.py script is modified slightly here. The existing static
GL initialization uses ScopedAllowIO on some platforms. This function is
banned so moving the code triggers presubmit errors. The GPU main thread
can't continue until initialization is finished anyways so moving
blocking code to a different thread isn't helpful. Add new exemptions to
PRESUBMIT.py.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/507532e60d484704354edd17a7b51904e7a97d88
Cr-Commit-Position: refs/heads/master@{#402259}

[kylechar, 2016-06-22 20:43:53]

Description was changed from

==========
Move static GL binding initialization to //ui/gl/init.

TODO.

BUG=611142
==========

to

==========
Move static GL binding initialization to //ui/gl/init.

TODO.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-06-24 13:58:35]

Description was changed from

==========
Move static GL binding initialization to //ui/gl/init.

TODO.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialziation is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's method to improve
readability.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-06-24 14:01:58]

Description was changed from

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialziation is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's method to improve
readability.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialziation is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's method to improve
readability.

The PRESUBMIT.py script is modified slightly here. The existing static
GL initialization uses ScopedAllowIO on some platforms. This function is
banned so moving the code triggers presubmit errors. The GPU main thread
can't continue until initialization is finished anyways so moving
blocking code to a different thread isn't helpful. Add new exemptions to
PRESUBMIT.py.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-06-24 14:33:01]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 14:33:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:10:27]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[kylechar, 2016-06-24 18:43:25]

kylechar@chromium.org changed reviewers:
+ piman@chromium.org

[kylechar, 2016-06-24 18:43:26]

This is a bit of big one. Sorry about that, it's essentially just moving all of
the static GL initialization between targets so that it can call out to Ozone.

[piman, 2016-06-24 19:13:21]

https://codereview.chromium.org/2094513002/diff/100001/ui/gl/init/gl_initiali...
File ui/gl/init/gl_initializer_android.cc (right):

https://codereview.chromium.org/2094513002/diff/100001/ui/gl/init/gl_initiali...
ui/gl/init/gl_initializer_android.cc:65: ::gl::g_driver_gl.fn.glDepthRangeFn =
MarshalDepthRangeToDepthRangef;
nit: all the EGL platforms have to do this, and they do it identically. Could we
move this to InitializeStaticGLBindingsEGL?

[piman, 2016-06-24 19:13:35]

lgtm

[kylechar, 2016-06-27 13:13:27]

Description was changed from

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialziation is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's method to improve
readability.

The PRESUBMIT.py script is modified slightly here. The existing static
GL initialization uses ScopedAllowIO on some platforms. This function is
banned so moving the code triggers presubmit errors. The GPU main thread
can't continue until initialization is finished anyways so moving
blocking code to a different thread isn't helpful. Add new exemptions to
PRESUBMIT.py.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialization is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's own method to improve
readability.

The PRESUBMIT.py script is modified slightly here. The existing static
GL initialization uses ScopedAllowIO on some platforms. This function is
banned so moving the code triggers presubmit errors. The GPU main thread
can't continue until initialization is finished anyways so moving
blocking code to a different thread isn't helpful. Add new exemptions to
PRESUBMIT.py.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-06-27 13:35:22]

Thanks for the quick review!

https://codereview.chromium.org/2094513002/diff/100001/ui/gl/init/gl_initiali...
File ui/gl/init/gl_initializer_android.cc (right):

https://codereview.chromium.org/2094513002/diff/100001/ui/gl/init/gl_initiali...
ui/gl/init/gl_initializer_android.cc:65: ::gl::g_driver_gl.fn.glDepthRangeFn =
MarshalDepthRangeToDepthRangef;
On 2016/06/24 19:13:21, piman wrote:
> nit: all the EGL platforms have to do this, and they do it identically. Could
we
> move this to InitializeStaticGLBindingsEGL?

Good idea, done.

[kylechar, 2016-06-27 13:41:43]

kylechar@chromium.org changed reviewers:
+ dpranke@chromium.org

[kylechar, 2016-06-27 13:41:44]

+dpranke for PRESUBMIT.py. I moved some code that used a banned function, which
makes presubmit unhappy.

The main thread has to block until initialization is finished anyways, so moving
the code to a different thread seems counter productive?

[Dirk Pranke, 2016-06-27 16:29:48]

lgtm based on piman@'s approval.

[kylechar, 2016-06-27 17:10:56]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-06-27 17:10:56]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2094513002/#ps120001
(title: "Fix for comment.")

[commit-bot: I haz the power, 2016-06-27 17:11:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 19:47:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-27 19:49:42]

Description was changed from

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialization is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's own method to improve
readability.

The PRESUBMIT.py script is modified slightly here. The existing static
GL initialization uses ScopedAllowIO on some platforms. This function is
banned so moving the code triggers presubmit errors. The GPU main thread
can't continue until initialization is finished anyways so moving
blocking code to a different thread isn't helpful. Add new exemptions to
PRESUBMIT.py.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move static GL binding initialization to //ui/gl/init.

Static GL binding initialization needs to call out to the Ozone
platform. Move this initialization code from //ui/gl to //ui/gl/init as
part of larger effort to break //ui/gl dep on //ui/ozone. Also move
InitializationDebugGLBindings() and ClearGLBindings() in a similar
fashion as they are closely linked to static initialization.

Unfortunately, dynamic GL binding initialization can't be moved
//ui/gl/init. It would be nice to have all the initialization code in
one target but dynamic GL binding initialization is used by GLContext.

The existing InitializationStaticGLBindings() functions had grown to be
very large for some platforms. Where appropriate the code for each
implementation has been extracted into it's own method to improve
readability.

The PRESUBMIT.py script is modified slightly here. The existing static
GL initialization uses ScopedAllowIO on some platforms. This function is
banned so moving the code triggers presubmit errors. The GPU main thread
can't continue until initialization is finished anyways so moving
blocking code to a different thread isn't helpful. Add new exemptions to
PRESUBMIT.py.

BUG=611142
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/507532e60d484704354edd17a7b51904e7a97d88
Cr-Commit-Position: refs/heads/master@{#402259}
==========

[commit-bot: I haz the power, 2016-06-27 19:49:44]

Patchset 7 (id:??) landed as
https://crrev.com/507532e60d484704354edd17a7b51904e7a97d88
Cr-Commit-Position: refs/heads/master@{#402259}

[Lambros, 2016-06-27 21:19:22]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2099163003/ by lambroslambrou@chromium.org.

The reason for reverting is: Suspected of breaking Official "win trunk" builder:
c:\b\build\slave\win_trunk\build\src\ui\gl\init\gl_initializer_win.cc(32): fatal
error C1083: Cannot open include file: 'software_renderer.h': No such file or
directory
Please see crbug.com/623657 for details.
.