PRESUBMIT.py - Issue 2094513002: Move static GL binding initialization to //ui/gl/init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2094513002: Move static GL binding initialization to //ui/gl/init. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for comment. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 134f62dea44f8d3f034aff7d6d7d4cae9e9e3f94..731fca779997077c2718449fbac67ad381e32bb4 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -187,10 +187,13 @@ _BANNED_CPP_FUNCTIONS = (

r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",

r"^remoting[\\\/]host[\\\/]security_key[\\\/]"

"gnubby_auth_handler_linux\.cc$",

- r"^ui[\\\/]ozone[\\\/]platform[\\\/]drm[\\\/]host[\\\/]"

- "drm_display_host_manager\.cc$",

r"^ui[\\\/]base[\\\/]material_design[\\\/]"

"material_design_controller\.cc$",

+ r"^ui[\\\/]gl[\\\/]init[\\\/]gl_initializer_mac\.cc$",

+ r"^ui[\\\/]gl[\\\/]init[\\\/]gl_initializer_win\.cc$",

+ r"^ui[\\\/]gl[\\\/]init[\\\/]gl_initializer_x11\.cc$",

+ r"^ui[\\\/]ozone[\\\/]platform[\\\/]drm[\\\/]host[\\\/]"

+ "drm_display_host_manager\.cc$",

(

« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc » ('j') | no next file with comments »