Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Issue 2092413002: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. (Closed)

Created:
4 years, 6 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[RegisterConfiguration] Streamline access to arch defaults, simplify Registers. Replaces ArchDefault method with Crankshaft and Turbofan getters. Eliminates IsAllocated method on Register, FloatRegister, DoubleRegister. Eliminates ToString method too. Changes call sites to access appropriate arch default RegisterConfiguration. LOG=N BUG= Committed: https://crrev.com/257336d26a9b4f8efad872d3166a5ac3742e9adc Cr-Commit-Position: refs/heads/master@{#37297}

Patch Set 1 #

Patch Set 2 : Clean up. #

Patch Set 3 : Eliminate Register::ToString methods. #

Patch Set 4 : Fix ARM. #

Patch Set 5 : Rebase. #

Patch Set 6 : Try to fix patch errors. #

Patch Set 7 : Rebase. #

Patch Set 8 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -452 lines) Patch
M src/arm/assembler-arm.h View 1 2 3 4 5 6 3 chunks +0 lines, -9 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 10 chunks +20 lines, -43 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-gap-resolver-arm64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-gap-resolver-ia32.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 2 5 chunks +6 lines, -4 lines 0 comments Download
M src/crankshaft/lithium-allocator.cc View 1 2 6 chunks +10 lines, -16 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/crankshaft/x87/lithium-gap-resolver-x87.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/deoptimizer.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/frames.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 2 3 4 5 6 3 chunks +0 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 1 chunk +6 lines, -2 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M src/register-configuration.h View 1 2 3 4 5 6 4 chunks +15 lines, -8 lines 0 comments Download
M src/register-configuration.cc View 1 2 3 4 5 6 5 chunks +15 lines, -14 lines 0 comments Download
M src/s390/assembler-s390.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M src/s390/deoptimizer-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/s390/disasm-s390.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 3 4 5 6 2 chunks +0 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x87/assembler-x87.h View 1 2 3 4 5 6 3 chunks +0 lines, -7 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 17 chunks +44 lines, -107 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-code-stubs-ia32.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-code-stubs-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/test-code-stubs-x87.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bbudge
This is pretty mechanical. I made it easier to get the arch default RegisterConfigurations. Perhaps ...
4 years, 5 months ago (2016-06-26 22:15:03 UTC) #3
Jarin
lgtm. Thanks!
4 years, 5 months ago (2016-06-27 07:19:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092413002/140001
4 years, 5 months ago (2016-06-27 14:50:31 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 5 months ago (2016-06-27 15:30:04 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 15:31:47 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/257336d26a9b4f8efad872d3166a5ac3742e9adc
Cr-Commit-Position: refs/heads/master@{#37297}

Powered by Google App Engine
This is Rietveld 408576698