Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: src/crankshaft/arm64/lithium-gap-resolver-arm64.h

Issue 2092413002: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compile. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/arm64/lithium-gap-resolver-arm64.h
diff --git a/src/crankshaft/arm64/lithium-gap-resolver-arm64.h b/src/crankshaft/arm64/lithium-gap-resolver-arm64.h
index 4f5eb223d42fffbbec248e4fba07c576d264ea0f..acac4e19ffd069f9d5801e62601e5f10647ebdf3 100644
--- a/src/crankshaft/arm64/lithium-gap-resolver-arm64.h
+++ b/src/crankshaft/arm64/lithium-gap-resolver-arm64.h
@@ -66,7 +66,8 @@ class LGapResolver BASE_EMBEDDED {
// Registers used to solve cycles.
const Register& SavedValueRegister() {
- DCHECK(!masm_.ScratchRegister().IsAllocatable());
+ DCHECK(!RegisterConfiguration::Crankshaft()->IsAllocatableGeneralCode(
+ masm_.ScratchRegister().code()));
return masm_.ScratchRegister();
}
// The scratch register is used to break cycles and to store constant.
@@ -77,7 +78,8 @@ class LGapResolver BASE_EMBEDDED {
// We use the Crankshaft floating-point scratch register to break a cycle
// involving double values as the MacroAssembler will not need it for the
// operations performed by the gap resolver.
- DCHECK(!crankshaft_fp_scratch.IsAllocatable());
+ DCHECK(!RegisterConfiguration::Crankshaft()->IsAllocatableGeneralCode(
+ crankshaft_fp_scratch.code()));
return crankshaft_fp_scratch;
}
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698