Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/assembler.cc

Issue 2092413002: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compile. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/compiler/graph-visualizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index c355105f35f70de7158cd0fd4b9baa320ca49467..c7e819ae4250081af561e5198ca25f897816ca16 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -114,56 +114,6 @@ namespace v8 {
namespace internal {
// -----------------------------------------------------------------------------
-// Common register code.
-
-const char* Register::ToString() {
- // This is the mapping of allocation indices to registers.
- DCHECK(reg_code >= 0 && reg_code < kNumRegisters);
- return RegisterConfiguration::ArchDefault(RegisterConfiguration::CRANKSHAFT)
- ->GetGeneralRegisterName(reg_code);
-}
-
-bool Register::IsAllocatable(
- RegisterConfiguration::CompilerSelector compiler) const {
- return ((1 << reg_code) &
- RegisterConfiguration::ArchDefault(compiler)
- ->allocatable_general_codes_mask()) != 0;
-}
-
-const char* DoubleRegister::ToString() {
- // This is the mapping of allocation indices to registers.
- DCHECK(reg_code >= 0 && reg_code < kMaxNumRegisters);
- return RegisterConfiguration::ArchDefault(RegisterConfiguration::CRANKSHAFT)
- ->GetDoubleRegisterName(reg_code);
-}
-
-bool DoubleRegister::IsAllocatable(
- RegisterConfiguration::CompilerSelector compiler) const {
- return ((1 << reg_code) &
- RegisterConfiguration::ArchDefault(compiler)
- ->allocatable_double_codes_mask()) != 0;
-}
-
-// FloatRegister is only a distinct type on ARM. On all other platforms it's
-// typedef'ed to DoubleRegister.
-#if V8_TARGET_ARCH_ARM
-const char* FloatRegister::ToString() {
- // This is the mapping of allocation indices to registers.
- DCHECK(reg_code >= 0 && reg_code < kMaxNumRegisters);
- return RegisterConfiguration::ArchDefault(RegisterConfiguration::CRANKSHAFT)
- ->GetFloatRegisterName(reg_code);
-}
-
-bool FloatRegister::IsAllocatable(
- RegisterConfiguration::CompilerSelector compiler) const {
- // TODO(bbudge) Update this once RegisterConfigutation handles aliasing.
- return ((1 << reg_code) &
- RegisterConfiguration::ArchDefault(RegisterConfiguration::CRANKSHAFT)
- ->allocatable_double_codes_mask()) != 0;
-}
-#endif // V8_TARGET_ARCH_ARM
-
-// -----------------------------------------------------------------------------
// Common double constants.
struct DoubleConstant BASE_EMBEDDED {
« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/compiler/graph-visualizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698