src/x64/code-stubs-x64.h - Issue 2092413002: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.h

Issue 2092413002: [RegisterConfiguration] Streamline access to arch defaults, simplify Registers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix compile. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/code-stubs-x64.h

diff --git a/src/x64/code-stubs-x64.h b/src/x64/code-stubs-x64.h

index d4f8b29dbc091f856a809acf6248313de0f1e64a..a1813772218520a69ab62b3f3901059991559fb3 100644

--- a/src/x64/code-stubs-x64.h

+++ b/src/x64/code-stubs-x64.h

@@ -295,8 +295,8 @@ class RecordWriteStub: public PlatformCodeStub {

for (int i = 0; i < Register::kNumRegisters; i++) {

- Register candidate = Register::from_code(i);

- if (candidate.IsAllocatable()) {

+ if (RegisterConfiguration::Crankshaft()->IsAllocatableGeneralCode(i)) {

+ Register candidate = Register::from_code(i);

if (candidate.is(rcx)) continue;

if (candidate.is(r1)) continue;

if (candidate.is(r2)) continue;

« no previous file with comments | « src/x64/assembler-x64.h ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »