Get rid of NULLs in xfa/fxbarcode/

Get rid of NULLs in xfa/fxbarcode/

Committed: https://pdfium.googlesource.com/pdfium/+/6dc1d7753691c0ff2f390e8ffd95a3182064487e

[Lei Zhang, 2016-06-09 18:22:40]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-06-09 18:40:06]

lgtm w/ nits.

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_CommonECI.cpp (right):

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_CommonECI.cpp:37: return nullptr;
nit: this can be removed since we always return nullptr afterwards.

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/datamatri...
File xfa/fxbarcode/datamatrix/BC_SymbolInfo.cpp (right):

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/datamatri...
xfa/fxbarcode/datamatrix/BC_SymbolInfo.cpp:169: }
nit: returns nullptr in both cases, remove?

[Lei Zhang, 2016-06-09 22:31:48]

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_CommonECI.cpp (right):

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_CommonECI.cpp:37: return nullptr;
On 2016/06/09 18:40:06, dsinclair wrote:
> nit: this can be removed since we always return nullptr afterwards.

I suspect CBC_CommonECI is not all that useful. I'll follow up in a separate CL
to examine the situation here.

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/datamatri...
File xfa/fxbarcode/datamatrix/BC_SymbolInfo.cpp (right):

https://codereview.chromium.org/2048983002/diff/20001/xfa/fxbarcode/datamatri...
xfa/fxbarcode/datamatrix/BC_SymbolInfo.cpp:169: }
On 2016/06/09 18:40:06, dsinclair wrote:
> nit: returns nullptr in both cases, remove?

Done.

[Lei Zhang, 2016-06-09 22:32:10]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-06-09 22:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2048983002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-06-09 22:32:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048983002/60001

[commit-bot: I haz the power, 2016-06-10 00:32:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 00:32:53]

Try jobs failed on following builders:
  mac on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  mac_no_v8 on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  mac_xfa on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  mac_xfa_rel_gn on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)

[Lei Zhang, 2016-06-10 00:45:42]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-10 00:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048983002/60001

[commit-bot: I haz the power, 2016-06-10 01:39:35]

Description was changed from

==========
Get rid of NULLs in xfa/fxbarcode/
==========

to

==========
Get rid of NULLs in xfa/fxbarcode/

Committed:
https://pdfium.googlesource.com/pdfium/+/6dc1d7753691c0ff2f390e8ffd95a3182064...
==========

[commit-bot: I haz the power, 2016-06-10 01:39:37]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6dc1d7753691c0ff2f390e8ffd95a3182064...

[commit-bot: I haz the power, 2016-06-10 01:39:39]

CQ bit was unchecked