Get rid of NULLs in xfa/fxbarcode/

xfa/fxbarcode/qrcode/BC_QRFinderPatternFinder.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2007 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 148 matching lines @@
       if (confirmed) {
         iSkip = stateCount[0];
         if (m_hasSkipped) {
           done = HaveMultiplyConfirmedCenters();
         }
       }
     }
   }
   std::unique_ptr<CFX_ArrayTemplate<CBC_QRFinderPattern*>> patternInfo(
       SelectBestpatterns(e));
-  BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+  BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);
   OrderBestPatterns(patternInfo.get());
   return new CBC_QRFinderPatternInfo(patternInfo.get());
 }
 void CBC_QRFinderPatternFinder::OrderBestPatterns(
     CFX_ArrayTemplate<CBC_QRFinderPattern*>* patterns) {
   FX_FLOAT abDistance = Distance((*patterns)[0], (*patterns)[1]);
   FX_FLOAT bcDistance = Distance((*patterns)[1], (*patterns)[2]);
   FX_FLOAT acDistance = Distance((*patterns)[0], (*patterns)[2]);
   CBC_QRFinderPattern* topLeft;
   CBC_QRFinderPattern* topRight;
@@ skipping 213 matching lines @@
       return TRUE;
     }
   }
   return FALSE;
 }
 int32_t CBC_QRFinderPatternFinder::FindRowSkip() {
   int32_t max = m_possibleCenters.GetSize();
   if (max <= 1) {
     return 0;
   }
-  FinderPattern* firstConfirmedCenter = NULL;
+  FinderPattern* firstConfirmedCenter = nullptr;
   for (int32_t i = 0; i < max; i++) {
     CBC_QRFinderPattern* center = m_possibleCenters[i];
     if (center->GetCount() >= CENTER_QUORUM) {
-      if (firstConfirmedCenter == NULL) {
-        firstConfirmedCenter = center;
-      } else {
+      if (firstConfirmedCenter) {
         m_hasSkipped = TRUE;
         return (int32_t)((fabs(firstConfirmedCenter->GetX() - center->GetX()) -
                           fabs(firstConfirmedCenter->GetY() - center->GetY())) /
                          2);
       }
+      firstConfirmedCenter = center;
     }
   }
   return 0;
 }
 FX_BOOL CBC_QRFinderPatternFinder::HaveMultiplyConfirmedCenters() {
   int32_t confirmedCount = 0;
   FX_FLOAT totalModuleSize = 0.0f;
   int32_t max = m_possibleCenters.GetSize();
   int32_t i;
   for (i = 0; i < max; i++) {
@@ skipping 13 matching lines @@
     totalDeviation += fabs(pattern->GetEstimatedModuleSize() - average);
   }
   return totalDeviation <= 0.05f * totalModuleSize;
 }
 
 CFX_ArrayTemplate<CBC_QRFinderPattern*>*
 CBC_QRFinderPatternFinder::SelectBestpatterns(int32_t& e) {
   int32_t startSize = m_possibleCenters.GetSize();
   if (m_possibleCenters.GetSize() < 3) {
     e = BCExceptionRead;
-    BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+    BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);
   }
   FX_FLOAT average = 0.0f;
   if (startSize > 3) {
     FX_FLOAT totalModuleSize = 0.0f;
     for (int32_t i = 0; i < startSize; i++)
       totalModuleSize += m_possibleCenters[i]->GetEstimatedModuleSize();
 
     average = totalModuleSize / (FX_FLOAT)startSize;
     for (int32_t j = 0;
          j < m_possibleCenters.GetSize() && m_possibleCenters.GetSize() > 3;
@@ skipping 14 matching lines @@
               });
   }
   CFX_ArrayTemplate<CBC_QRFinderPattern*>* vec =
       new CFX_ArrayTemplate<CBC_QRFinderPattern*>();
   vec->SetSize(3);
   (*vec)[0] = m_possibleCenters[0]->Clone();
   (*vec)[1] = m_possibleCenters[1]->Clone();
   (*vec)[2] = m_possibleCenters[2]->Clone();
   return vec;
 }