Get rid of NULLs in xfa/fxbarcode/

xfa/fxbarcode/common/BC_CommonECI.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2008 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 16 matching lines @@
 CBC_CommonECI::CBC_CommonECI(int32_t value) {
   m_value = value;
 }
 CBC_CommonECI::~CBC_CommonECI() {}
 int32_t CBC_CommonECI::GetValue() {
   return m_value;
 }
 CBC_CommonECI* CBC_CommonECI::GetEICByValue(int32_t value, int32_t& e) {
   if (value < 0 || value > 999999) {
     e = BCExceptionBadECI;
-    return NULL;
+    return nullptr;

[dsinclair, 2016/06/09 18:40:06]

nit: this can be removed since we always return nullptr afterwards.

[Lei Zhang, 2016/06/09 22:31:47]

I suspect CBC_CommonECI is not all that useful. I'll follow up in a separate CL
to examine the situation here.

   }
-  if (value < 900) {
-  }
-  return NULL;
+  return nullptr;
 }