Get rid of NULLs in xfa/fxbarcode/

xfa/fxbarcode/pdf417/BC_PDF417Detector.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2009 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 39 matching lines @@
 int32_t CBC_Detector::BARCODE_MIN_HEIGHT = 10;
 
 CBC_Detector::CBC_Detector() {}
 CBC_Detector::~CBC_Detector() {}
 
 CBC_PDF417DetectorResult* CBC_Detector::detect(CBC_BinaryBitmap* image,
                                                int32_t hints,
                                                FX_BOOL multiple,
                                                int32_t& e) {
   CBC_CommonBitMatrix* bitMatrix = image->GetBlackMatrix(e);
-  BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+  BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);
   CBC_ResultPointArrayArray* barcodeCoordinates = detect(multiple, bitMatrix);
   if (barcodeCoordinates->GetSize() == 0) {
     rotate180(bitMatrix);
     barcodeCoordinates = detect(multiple, bitMatrix);
   }
   if (barcodeCoordinates->GetSize() == 0) {
     e = BCExceptionUnSupportedBarcode;
-    BC_EXCEPTION_CHECK_ReturnValue(e, NULL);
+    BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);
   }
   return new CBC_PDF417DetectorResult(bitMatrix, barcodeCoordinates);
 }
 void CBC_Detector::rotate180(CBC_CommonBitMatrix* bitMatrix) {
   int32_t width = bitMatrix->GetWidth();
   int32_t height = bitMatrix->GetHeight();
   CBC_CommonBitArray* firstRowBitArray = new CBC_CommonBitArray(width);
   CBC_CommonBitArray* secondRowBitArray = new CBC_CommonBitArray(width);
   CBC_CommonBitArray* tmpBitArray = new CBC_CommonBitArray(width);
   for (int32_t y = 0; y<(height + 1)>> 1; y++) {
@@ skipping 29 matching lines @@
 
 CBC_ResultPointArrayArray* CBC_Detector::detect(
     FX_BOOL multiple,
     CBC_CommonBitMatrix* bitMatrix) {
   CBC_ResultPointArrayArray* barcodeCoordinates = new CBC_ResultPointArrayArray;
   int32_t row = 0;
   int32_t column = 0;
   FX_BOOL foundBarcodeInRow = FALSE;
   while (row < bitMatrix->GetHeight()) {
     CBC_ResultPointArray* vertices = findVertices(bitMatrix, row, column);
-    if (vertices->GetAt(0) == NULL && vertices->GetAt(3) == NULL) {
+    if (!vertices->GetAt(0) && !vertices->GetAt(3)) {
       if (!foundBarcodeInRow) {
         delete vertices;
         break;
       }
       foundBarcodeInRow = FALSE;
       column = 0;
       for (int32_t i = 0; i < barcodeCoordinates->GetSize(); i++) {
         CBC_ResultPointArray* barcodeCoordinate = barcodeCoordinates->GetAt(i);
         if (barcodeCoordinate->GetAt(1)) {
           row = row > barcodeCoordinate->GetAt(1)->GetY();
@@ skipping 119 matching lines @@
       delete loc;
     }
     stopRow -= skippedRowCount + 1;
     result->SetAt(2, new CBC_ResultPoint((FX_FLOAT)previousRowLoc.GetAt(0),
                                          (FX_FLOAT)stopRow));
     result->SetAt(3, new CBC_ResultPoint((FX_FLOAT)previousRowLoc.GetAt(1),
                                          (FX_FLOAT)stopRow));
   }
   if (stopRow - startRow < BARCODE_MIN_HEIGHT) {
     for (int32_t i = 0; i < result->GetSize(); i++) {
-      result->SetAt(i, NULL);
+      result->SetAt(i, nullptr);
     }
   }
   return result;
 }
 CFX_Int32Array* CBC_Detector::findGuardPattern(CBC_CommonBitMatrix* matrix,
                                                int32_t column,
                                                int32_t row,
                                                int32_t width,
                                                FX_BOOL whiteFirst,
                                                int32_t* pattern,
@@ skipping 40 matching lines @@
   }
   if (counterPosition == patternLength - 1) {
     if (patternMatchVariance(counters, pattern, MAX_INDIVIDUAL_VARIANCE) <
         MAX_AVG_VARIANCE) {
       intarray->Add(patternStart);
       intarray->Add(x - 1);
       return intarray;
     }
   }
   delete intarray;
-  return NULL;
+  return nullptr;
 }
 int32_t CBC_Detector::patternMatchVariance(CFX_Int32Array& counters,
                                            int32_t* pattern,
                                            int32_t maxIndividualVariance) {
   int32_t numCounters = counters.GetSize();
   int32_t total = 0;
   int32_t patternLength = 0;
   for (int32_t i = 0; i < numCounters; i++) {
     total += counters[i];
     patternLength += pattern[i];
@@ skipping 10 matching lines @@
     int32_t scaledPattern = pattern[x] * unitBarWidth;
     int32_t variance = counter > scaledPattern ? counter - scaledPattern
                                                : scaledPattern - counter;
     if (variance > maxIndividualVariance) {
       return INTEGER_MAX;
     }
     totalVariance += variance;
   }
   return totalVariance / total;
 }