xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp - Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp

Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp

diff --git a/xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp b/xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp

index e68969ef306390fde8420f9d22faafe5abdc336e..894b5d3fad1ff34b23136ad8d3aad0a8bc019804 100644

--- a/xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp

+++ b/xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp

@@ -94,9 +94,8 @@ CFX_ByteString CBC_PDF417Reader::Decode(CBC_BinaryBitmap* image,

}

int32_t CBC_PDF417Reader::getMaxWidth(CBC_ResultPoint* p1,

CBC_ResultPoint* p2) {

- if (p1 == NULL || p2 == NULL) {

+ if (!p1 || !p2)

return 0;

- }

return (int32_t)FXSYS_fabs(p1->GetX() - p2->GetX());

}

int32_t CBC_PDF417Reader::getMinWidth(CBC_ResultPoint* p1,