xfa/fxbarcode/common/BC_CommonECI.cpp - Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/common/BC_CommonECI.cpp

Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/common/BC_CommonECI.cpp

diff --git a/xfa/fxbarcode/common/BC_CommonECI.cpp b/xfa/fxbarcode/common/BC_CommonECI.cpp

index 4e37aec566bd852320bb9f91a48e42909ec66c93..30d21310f47c4ae422bbd4f069fb4f102602c332 100644

--- a/xfa/fxbarcode/common/BC_CommonECI.cpp

+++ b/xfa/fxbarcode/common/BC_CommonECI.cpp

@@ -32,11 +32,7 @@ int32_t CBC_CommonECI::GetValue() {

return m_value;

}

CBC_CommonECI* CBC_CommonECI::GetEICByValue(int32_t value, int32_t& e) {

- if (value < 0 || value > 999999) {

+ if (value < 0 || value > 999999)

e = BCExceptionBadECI;

- return NULL;

- }

- if (value < 900) {

- }

- return NULL;

+ return nullptr;

}