Get rid of NULLs in xfa/fxbarcode/

xfa/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2013 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 49 matching lines @@
       m_isLeft ? boundingBox->getBottomLeft() : boundingBox->getBottomRight();
   int32_t firstRow = imageRowToCodewordIndex((int32_t)top->GetY());
   int32_t lastRow = imageRowToCodewordIndex((int32_t)bottom->GetY());
   FX_FLOAT averageRowHeight =
       (lastRow - firstRow) / (FX_FLOAT)barcodeMetadata.getRowCount();
   int32_t barcodeRow = -1;
   int32_t maxRowHeight = 1;
   int32_t currentRowHeight = 0;
   for (int32_t codewordsRow = firstRow; codewordsRow < lastRow;
        codewordsRow++) {
-    if (codewords->GetAt(codewordsRow) == NULL) {
+    if (!codewords->GetAt(codewordsRow))
       continue;
-    }
+
     CBC_Codeword* codeword = codewords->GetAt(codewordsRow);
     int32_t rowDifference = codeword->getRowNumber() - barcodeRow;
     if (rowDifference == 0) {
       currentRowHeight++;
     } else if (rowDifference == 1) {
       maxRowHeight =
           maxRowHeight > currentRowHeight ? maxRowHeight : currentRowHeight;
       currentRowHeight = 1;
       barcodeRow = codeword->getRowNumber();
     } else if (rowDifference < 0) {
-      codewords->SetAt(codewordsRow, NULL);
+      codewords->SetAt(codewordsRow, nullptr);
     } else if (codeword->getRowNumber() >= barcodeMetadata.getRowCount()) {
-      codewords->SetAt(codewordsRow, NULL);
+      codewords->SetAt(codewordsRow, nullptr);
     } else if (rowDifference > codewordsRow) {
-      codewords->SetAt(codewordsRow, NULL);
+      codewords->SetAt(codewordsRow, nullptr);
     } else {
       int32_t checkedRows;
       if (maxRowHeight > 2) {
         checkedRows = (maxRowHeight - 2) * rowDifference;
       } else {
         checkedRows = rowDifference;
       }
       FX_BOOL closePreviousCodewordFound = checkedRows >= codewordsRow;
       for (int32_t i = 1; i <= checkedRows && !closePreviousCodewordFound;
            i++) {
-        closePreviousCodewordFound = codewords->GetAt(codewordsRow - i) != NULL;
+        closePreviousCodewordFound = !!codewords->GetAt(codewordsRow - i);
       }
       if (closePreviousCodewordFound) {
-        codewords->SetAt(codewordsRow, NULL);
+        codewords->SetAt(codewordsRow, nullptr);
       } else {
         barcodeRow = codeword->getRowNumber();
         currentRowHeight = 1;
       }
     }
   }
   return (int32_t)(averageRowHeight + 0.5);
 }
 CFX_Int32Array* CBC_DetectionResultRowIndicatorColumn::getRowHeights(
     int32_t& e) {
   CBC_BarcodeMetadata* barcodeMetadata = getBarcodeMetadata();
-  if (barcodeMetadata == NULL) {
+  if (!barcodeMetadata) {
     e = BCExceptionCannotMetadata;
-    return NULL;
+    return nullptr;
   }
   adjustIncompleteIndicatorColumnRowNumbers(*barcodeMetadata);
   CFX_Int32Array* result = new CFX_Int32Array;
   result->SetSize(barcodeMetadata->getRowCount());
   for (int32_t i = 0; i < getCodewords()->GetSize(); i++) {
     CBC_Codeword* codeword = (CBC_Codeword*)getCodewords()->GetAt(i);
     if (codeword) {
       result->SetAt(codeword->getRowNumber(),
                     result->GetAt(codeword->getRowNumber()) + 1);
     }
@@ skipping 11 matching lines @@
   int32_t firstRow = imageRowToCodewordIndex((int32_t)top->GetY());
   int32_t lastRow = imageRowToCodewordIndex((int32_t)bottom->GetY());
   FX_FLOAT averageRowHeight =
       (lastRow - firstRow) / (FX_FLOAT)barcodeMetadata.getRowCount();
   CFX_ArrayTemplate<CBC_Codeword*>* codewords = getCodewords();
   int32_t barcodeRow = -1;
   int32_t maxRowHeight = 1;
   int32_t currentRowHeight = 0;
   for (int32_t codewordsRow = firstRow; codewordsRow < lastRow;
        codewordsRow++) {
-    if (codewords->GetAt(codewordsRow) == NULL) {
+    if (!codewords->GetAt(codewordsRow))
       continue;
-    }
+
     CBC_Codeword* codeword = codewords->GetAt(codewordsRow);
     codeword->setRowNumberAsRowIndicatorColumn();
     int32_t rowDifference = codeword->getRowNumber() - barcodeRow;
     if (rowDifference == 0) {
       currentRowHeight++;
     } else if (rowDifference == 1) {
       maxRowHeight =
           maxRowHeight > currentRowHeight ? maxRowHeight : currentRowHeight;
       currentRowHeight = 1;
       barcodeRow = codeword->getRowNumber();
     } else if (codeword->getRowNumber() >= barcodeMetadata.getRowCount()) {
-      codewords->SetAt(codewordsRow, NULL);
+      codewords->SetAt(codewordsRow, nullptr);
     } else {
       barcodeRow = codeword->getRowNumber();
       currentRowHeight = 1;
     }
   }
   return (int32_t)(averageRowHeight + 0.5);
 }
 CBC_BarcodeMetadata*
 CBC_DetectionResultRowIndicatorColumn::getBarcodeMetadata() {
   CFX_ArrayTemplate<CBC_Codeword*>* codewords = getCodewords();
   CBC_BarcodeValue barcodeColumnCount;
   CBC_BarcodeValue barcodeRowCountUpperPart;
   CBC_BarcodeValue barcodeRowCountLowerPart;
   CBC_BarcodeValue barcodeECLevel;
   for (int32_t i = 0; i < codewords->GetSize(); i++) {
     CBC_Codeword* codeword = codewords->GetAt(i);
-    if (codeword == NULL) {
+    if (!codeword)
       continue;
-    }
+
     codeword->setRowNumberAsRowIndicatorColumn();
     int32_t rowIndicatorValue = codeword->getValue() % 30;
     int32_t codewordRowNumber = codeword->getRowNumber();
     if (!m_isLeft) {
       codewordRowNumber += 2;
     }
     switch (codewordRowNumber % 3) {
       case 0:
         barcodeRowCountUpperPart.setValue(rowIndicatorValue * 3 + 1);
         break;
@@ skipping 10 matching lines @@
       (barcodeRowCountUpperPart.getValue()->GetSize() == 0) ||
       (barcodeRowCountLowerPart.getValue()->GetSize() == 0) ||
       (barcodeECLevel.getValue()->GetSize() == 0) ||
       barcodeColumnCount.getValue()->GetAt(0) < 1 ||
       barcodeRowCountUpperPart.getValue()->GetAt(0) +
               barcodeRowCountLowerPart.getValue()->GetAt(0) <
           CBC_PDF417Common::MIN_ROWS_IN_BARCODE ||
       barcodeRowCountUpperPart.getValue()->GetAt(0) +
               barcodeRowCountLowerPart.getValue()->GetAt(0) >
           CBC_PDF417Common::MAX_ROWS_IN_BARCODE) {
-    return NULL;
+    return nullptr;
   }
   CBC_BarcodeMetadata* barcodeMetadata =
       new CBC_BarcodeMetadata(barcodeColumnCount.getValue()->GetAt(0),
                               barcodeRowCountUpperPart.getValue()->GetAt(0),
                               barcodeRowCountLowerPart.getValue()->GetAt(0),
                               barcodeECLevel.getValue()->GetAt(0));
   removeIncorrectCodewords(codewords, *barcodeMetadata);
   return barcodeMetadata;
 }
 FX_BOOL CBC_DetectionResultRowIndicatorColumn::isLeft() {
   return m_isLeft;
 }
 CFX_ByteString CBC_DetectionResultRowIndicatorColumn::toString() {
   return CFX_ByteString("IsLeft: ") + m_isLeft + '\n' +
          CBC_DetectionResultColumn::toString();
 }
 void CBC_DetectionResultRowIndicatorColumn::removeIncorrectCodewords(
     CFX_ArrayTemplate<CBC_Codeword*>* codewords,
     CBC_BarcodeMetadata barcodeMetadata) {
   for (int32_t codewordRow = 0; codewordRow < codewords->GetSize();
        codewordRow++) {
     CBC_Codeword* codeword = codewords->GetAt(codewordRow);
-    if (codeword == NULL) {
+    if (!codeword)
       continue;
-    }
+
     int32_t rowIndicatorValue = codeword->getValue() % 30;
     int32_t codewordRowNumber = codeword->getRowNumber();
     if (codewordRowNumber > barcodeMetadata.getRowCount()) {
-      codewords->SetAt(codewordRow, NULL);
+      codewords->SetAt(codewordRow, nullptr);
       continue;
     }
     if (!m_isLeft) {
       codewordRowNumber += 2;
     }
     switch (codewordRowNumber % 3) {
       case 0:
         if (rowIndicatorValue * 3 + 1 !=
             barcodeMetadata.getRowCountUpperPart()) {
-          codewords->SetAt(codewordRow, NULL);
+          codewords->SetAt(codewordRow, nullptr);
         }
         break;
       case 1:
         if (rowIndicatorValue / 3 !=
                 barcodeMetadata.getErrorCorrectionLevel() ||
             rowIndicatorValue % 3 != barcodeMetadata.getRowCountLowerPart()) {
-          codewords->SetAt(codewordRow, NULL);
+          codewords->SetAt(codewordRow, nullptr);
         }
         break;
       case 2:
         if (rowIndicatorValue + 1 != barcodeMetadata.getColumnCount()) {
-          codewords->SetAt(codewordRow, NULL);
+          codewords->SetAt(codewordRow, nullptr);
         }
         break;
     }
   }
 }