xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp - Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonDecoder.cpp ('k') | xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

diff --git a/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp b/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

index 33771418d4571001291bda171af51be2c7804b24..da0ad3ff054a0063c799aca1f30a2ef8ec838565 100644

--- a/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

+++ b/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp

@@ -23,8 +23,8 @@

#include "xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h"

#include "xfa/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h"

-CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::QRCodeFild = NULL;

-CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::DataMatrixField = NULL;

+CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::QRCodeFild = nullptr;

+CBC_ReedSolomonGF256* CBC_ReedSolomonGF256::DataMatrixField = nullptr;

void CBC_ReedSolomonGF256::Initialize() {

QRCodeFild = new CBC_ReedSolomonGF256(0x011D);

QRCodeFild->Init();

@@ -73,11 +73,11 @@ CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::BuildMonomial(

int32_t& e) {

if (degree < 0) {

e = BCExceptionDegreeIsNegative;

- BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

+ BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

}

if (coefficient == 0) {

CBC_ReedSolomonGF256Poly* temp = m_zero->Clone(e);

- BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

+ BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

return temp;

}

CFX_Int32Array coefficients;

@@ -85,7 +85,7 @@ CBC_ReedSolomonGF256Poly* CBC_ReedSolomonGF256::BuildMonomial(

coefficients[0] = coefficient;

CBC_ReedSolomonGF256Poly* temp = new CBC_ReedSolomonGF256Poly();

temp->Init(this, &coefficients, e);

- BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

+ BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

return temp;

}

int32_t CBC_ReedSolomonGF256::AddOrSubtract(int32_t a, int32_t b) {