xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp - Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp

Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp

diff --git a/xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp b/xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp

index 765c1d613cb4618554b07c83aa2f75c5323c7fc0..43cf09e549d30c3991b29e6959459e527a06708b 100644

--- a/xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp

+++ b/xfa/fxbarcode/pdf417/BC_PDF417Writer.cpp

@@ -59,7 +59,7 @@ uint8_t* CBC_PDF417Writer::Encode(const CFX_WideString& contents,

encoder.setDimensions(30, 1, row, row);

}

encoder.generateBarcodeLogic(contents, m_iCorrectLevel, e);

- BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

+ BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

int32_t lineThickness = 2;

int32_t aspectRatio = 4;

CBC_BarcodeMatrix* barcodeMatrix = encoder.getBarcodeMatrix();