Get rid of NULLs in xfa/fxbarcode/

xfa/fxbarcode/pdf417/BC_PDF417DetectionResult.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 // Original code is licensed as follows:
 /*
  * Copyright 2013 ZXing authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
@@ skipping 104 matching lines @@
   int32_t unadjustedCount = adjustRowNumbersByRow();
   if (unadjustedCount == 0) {
     return 0;
   }
   for (int32_t barcodeColumn = 1; barcodeColumn < m_barcodeColumnCount + 1;
        barcodeColumn++) {
     CFX_ArrayTemplate<CBC_Codeword*>* codewords =
         m_detectionResultColumns[barcodeColumn]->getCodewords();
     for (int32_t codewordsRow = 0; codewordsRow < codewords->GetSize();
          codewordsRow++) {
-      if (codewords->GetAt(codewordsRow) == NULL) {
+      if (!codewords->GetAt(codewordsRow))
         continue;
-      }
+
       if (!codewords->GetAt(codewordsRow)->hasValidRowNumber()) {
         adjustRowNumbers(barcodeColumn, codewordsRow, codewords);
       }
     }
   }
   return unadjustedCount;
 }
 int32_t CBC_DetectionResult::adjustRowNumbersByRow() {
   adjustRowNumbersFromBothRI();
   int32_t unadjustedCount = adjustRowNumbersFromLRI();
@@ skipping 35 matching lines @@
 }
 int32_t CBC_DetectionResult::adjustRowNumbersFromRRI() {
   if (!m_detectionResultColumns[m_barcodeColumnCount + 1]) {
     return 0;
   }
   int32_t unadjustedCount = 0;
   CFX_ArrayTemplate<CBC_Codeword*>* codewords =
       m_detectionResultColumns.GetAt(m_barcodeColumnCount + 1)->getCodewords();
   for (int32_t codewordsRow = 0; codewordsRow < codewords->GetSize();
        codewordsRow++) {
-    if (codewords->GetAt(codewordsRow) == NULL) {
+    if (!codewords->GetAt(codewordsRow))
       continue;
-    }
+
     int32_t rowIndicatorRowNumber =
         codewords->GetAt(codewordsRow)->getRowNumber();
     int32_t invalidRowCounts = 0;
     for (int32_t barcodeColumn = m_barcodeColumnCount + 1;
          barcodeColumn > 0 && invalidRowCounts < ADJUST_ROW_NUMBER_SKIP;
          barcodeColumn--) {
       CBC_Codeword* codeword = m_detectionResultColumns.GetAt(barcodeColumn)
                                    ->getCodewords()
                                    ->GetAt(codewordsRow);
       if (codeword) {
         invalidRowCounts = adjustRowNumberIfValid(rowIndicatorRowNumber,
                                                   invalidRowCounts, codeword);
         if (!codeword->hasValidRowNumber()) {
           unadjustedCount++;
         }
       }
     }
   }
   return unadjustedCount;
 }
 int32_t CBC_DetectionResult::adjustRowNumbersFromLRI() {
-  if (m_detectionResultColumns[0] == NULL) {
+  if (!m_detectionResultColumns[0])
     return 0;
-  }
+
   int32_t unadjustedCount = 0;
   CFX_ArrayTemplate<CBC_Codeword*>* codewords =
       m_detectionResultColumns.GetAt(0)->getCodewords();
   for (int32_t codewordsRow = 0; codewordsRow < codewords->GetSize();
        codewordsRow++) {
-    if (codewords->GetAt(codewordsRow) == NULL) {
+    if (!codewords->GetAt(codewordsRow))
       continue;
-    }
+
     int32_t rowIndicatorRowNumber =
         codewords->GetAt(codewordsRow)->getRowNumber();
     int32_t invalidRowCounts = 0;
     for (int32_t barcodeColumn = 1; barcodeColumn < m_barcodeColumnCount + 1 &&
                                     invalidRowCounts < ADJUST_ROW_NUMBER_SKIP;
          barcodeColumn++) {
       CBC_Codeword* codeword =
           m_detectionResultColumns[barcodeColumn]->getCodewords()->GetAt(
               codewordsRow);
       if (codeword) {
         invalidRowCounts = adjustRowNumberIfValid(rowIndicatorRowNumber,
                                                   invalidRowCounts, codeword);
         if (!codeword->hasValidRowNumber()) {
           unadjustedCount++;
         }
       }
     }
   }
   return unadjustedCount;
 }
 int32_t CBC_DetectionResult::adjustRowNumberIfValid(
     int32_t rowIndicatorRowNumber,
     int32_t invalidRowCounts,
     CBC_Codeword* codeword) {
-  if (codeword == NULL) {
+  if (!codeword)
     return invalidRowCounts;
-  }
+
   if (!codeword->hasValidRowNumber()) {
     if (codeword->isValidRowNumber(rowIndicatorRowNumber)) {
       codeword->setRowNumber(rowIndicatorRowNumber);
       invalidRowCounts = 0;
     } else {
       ++invalidRowCounts;
     }
   }
   return invalidRowCounts;
 }
@@ skipping 36 matching lines @@
   }
   for (int32_t i = 0; i < otherCodewords.GetSize(); i++) {
     CBC_Codeword* otherCodeword = otherCodewords.GetAt(i);
     if (adjustRowNumber(codeword, otherCodeword)) {
       return;
     }
   }
 }
 FX_BOOL CBC_DetectionResult::adjustRowNumber(CBC_Codeword* codeword,
                                              CBC_Codeword* otherCodeword) {
-  if (otherCodeword == NULL) {
+  if (!otherCodeword)
     return FALSE;
-  }
+
   if (otherCodeword->hasValidRowNumber() &&
       otherCodeword->getBucket() == codeword->getBucket()) {
     codeword->setRowNumber(otherCodeword->getRowNumber());
     return TRUE;
   }
   return FALSE;
 }
 int32_t CBC_DetectionResult::getBarcodeColumnCount() {
   return m_barcodeColumnCount;
 }
 int32_t CBC_DetectionResult::getBarcodeRowCount() {
   return m_barcodeMetadata->getRowCount();
 }
 int32_t CBC_DetectionResult::getBarcodeECLevel() {
   return m_barcodeMetadata->getErrorCorrectionLevel();
 }