xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp - Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp

Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp

diff --git a/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp b/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp

index 40e5fa6625a5febbe0722288e5d7235a2fe7dc3c..352dc3dab12912b288a6f71f3fbb599d9471c009 100644

--- a/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp

+++ b/xfa/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp

@@ -44,10 +44,10 @@ CBC_ReedSolomonGF256Poly* CBC_ReedSolomonEncoder::BuildGenerator(int32_t degree,

temp.Add(m_field->Exp(d - 1));

CBC_ReedSolomonGF256Poly temp_poly;

temp_poly.Init(m_field, &temp, e);

- BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

+ BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

CBC_ReedSolomonGF256Poly* nextGenerator =

lastGenerator->Multiply(&temp_poly, e);

- BC_EXCEPTION_CHECK_ReturnValue(e, NULL);

+ BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

m_cachedGenerators.Add(nextGenerator);

lastGenerator = nextGenerator;

}