Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make PropertyReference value() return a const CSSValue& Make PropertyReference value() return a const CSSValue& instead of a const CSSValue*. Since a Property cannot have a null CSSValue, this is more semantically correct and safe. BUG=526586 Committed: https://crrev.com/c516fb70c460da1d6f1b8d11aa276d8ece48eda3 Cr-Commit-Position: refs/heads/master@{#406526}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.h View 1 4 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
sashab
4 years, 6 months ago (2016-06-09 05:59:45 UTC) #2
sashab
Haraken ptal! :)
4 years, 5 months ago (2016-07-20 02:48:36 UTC) #8
haraken
LGTM
4 years, 5 months ago (2016-07-20 07:16:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2044023005/20001
4 years, 5 months ago (2016-07-20 07:18:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 12:52:00 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 12:53:55 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c516fb70c460da1d6f1b8d11aa276d8ece48eda3
Cr-Commit-Position: refs/heads/master@{#406526}

Powered by Google App Engine
This is Rietveld 408576698