third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp - Issue 2044023005: Make PropertyReference value() return a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.cpp ('k') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

index e43ed937975c362dc30a92c798e6df95cc720a84..78a1c61a723bc3c84343a33abf4da3fe4cef3bba 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

@@ -91,14 +91,14 @@ static StringKeyframeEffectModel* createKeyframeEffectModel(StyleResolver* resol

CSSPropertyID property = properties.propertyAt(j).id();

specifiedPropertiesForUseCounter.add(property);

if (property == CSSPropertyAnimationTimingFunction) {

- const CSSValue* value = properties.propertyAt(j).value();

+ const CSSValue& value = properties.propertyAt(j).value();

RefPtr<TimingFunction> timingFunction;

- if (value->isInheritedValue() && parentStyle->animations()) {

+ if (value.isInheritedValue() && parentStyle->animations()) {

timingFunction = parentStyle->animations()->timingFunctionList()[0];

- } else if (value->isValueList()) {

- timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value)->item(0));

+ } else if (value.isValueList()) {

+ timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value).item(0));

} else {

- ASSERT(value->isCSSWideKeyword());

+ DCHECK(value.isCSSWideKeyword());

timingFunction = CSSTimingData::initialTimingFunction();

}

keyframe->setEasing(timingFunction.release());