Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
index e43ed937975c362dc30a92c798e6df95cc720a84..78a1c61a723bc3c84343a33abf4da3fe4cef3bba 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
@@ -91,14 +91,14 @@ static StringKeyframeEffectModel* createKeyframeEffectModel(StyleResolver* resol
CSSPropertyID property = properties.propertyAt(j).id();
specifiedPropertiesForUseCounter.add(property);
if (property == CSSPropertyAnimationTimingFunction) {
- const CSSValue* value = properties.propertyAt(j).value();
+ const CSSValue& value = properties.propertyAt(j).value();
RefPtr<TimingFunction> timingFunction;
- if (value->isInheritedValue() && parentStyle->animations()) {
+ if (value.isInheritedValue() && parentStyle->animations()) {
timingFunction = parentStyle->animations()->timingFunctionList()[0];
- } else if (value->isValueList()) {
- timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value)->item(0));
+ } else if (value.isValueList()) {
+ timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value).item(0));
} else {
- ASSERT(value->isCSSWideKeyword());
+ DCHECK(value.isCSSWideKeyword());
timingFunction = CSSTimingData::initialTimingFunction();
}
keyframe->setEasing(timingFunction.release());

Powered by Google App Engine
This is Rietveld 408576698