third_party/WebKit/Source/core/dom/Element.cpp - Issue 2044023005: Make PropertyReference value() return a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index fc38c794e94278e4516a9883ffa4d8068317b190..c3faafd5b894f3f8dc9e509a2b3297767decadcf 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -3265,7 +3265,7 @@ static bool needsURLResolutionForInlineStyle(const Element& element, const Docum

return false;

for (unsigned i = 0; i < style->propertyCount(); ++i) {

// FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSCursorImageValue, etc.

- if (style->propertyAt(i).value()->isImageValue())

+ if (style->propertyAt(i).value().isImageValue())

return true;

}

return false;

@@ -3276,8 +3276,8 @@ static void reResolveURLsInInlineStyle(const Document& document, MutableStylePro

for (unsigned i = 0; i < style.propertyCount(); ++i) {

StylePropertySet::PropertyReference property = style.propertyAt(i);

// FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSCursorImageValue, etc.

- if (property.value()->isImageValue())

- toCSSImageValue(property.value())->reResolveURL(document);

+ if (property.value().isImageValue())

+ toCSSImageValue(property.value()).reResolveURL(document);

}