Make PropertyReference value() return a const CSSValue&

third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 32 matching lines @@
         return;
 
     StylePropertySet::PropertyReference allProperty = m_propertySet->propertyAt(m_allIndex);
     for (unsigned i = 0; i < m_propertySet->propertyCount(); ++i) {
         StylePropertySet::PropertyReference property = m_propertySet->propertyAt(i);
         if (CSSProperty::isAffectedByAllProperty(property.id())) {
             if (allProperty.isImportant() && !property.isImportant())
                 continue;
             if (static_cast<unsigned>(m_allIndex) >= i)
                 continue;
-            if (property.value()->equals(*allProperty.value())
+            if (property.value().equals(allProperty.value())
                 && property.isImportant() == allProperty.isImportant())
                 continue;
             m_needToExpandAll = true;
         }
         if (property.id() < firstCSSProperty || property.id() > lastCSSProperty)
             continue;
         m_longhandPropertyUsed.set(property.id() - firstCSSProperty);
     }
 }
 
@@ skipping 16 matching lines @@
 
     CSSPropertyID propertyID = static_cast<CSSPropertyID>(index + firstCSSProperty);
     ASSERT(firstCSSProperty <= propertyID && propertyID <= lastCSSProperty);
     if (m_longhandPropertyUsed.test(index)) {
         int index = m_propertySet->findPropertyIndex(propertyID);
         ASSERT(index != -1);
         return StylePropertySerializer::PropertyValueForSerializer(m_propertySet->propertyAt(index));
     }
 
     StylePropertySet::PropertyReference property = m_propertySet->propertyAt(m_allIndex);
-    return StylePropertySerializer::PropertyValueForSerializer(propertyID, property.value(), property.isImportant());
+    return StylePropertySerializer::PropertyValueForSerializer(propertyID, &property.value(), property.isImportant());
 }
 
 bool StylePropertySerializer::StylePropertySetForSerializer::shouldProcessPropertyAt(unsigned index) const
 {
     // StylePropertySet has all valid longhands. We should process.
     if (!hasAllProperty())
         return true;
 
     // If all is not expanded, we need to process "all" and properties which
     // are not overwritten by "all".
@@ skipping 787 matching lines @@
             builder.append(", ");
 
         const CSSValue& xValue = repeatXList ? repeatXList->item(i % repeatXList->length()) : repeatX;
         const CSSValue& yValue = repeatYList ? repeatYList->item(i % repeatYList->length()) : repeatY;
         appendBackgroundRepeatValue(builder, xValue, yValue);
     }
     return builder.toString();
 }
 
 } // namespace blink