third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp - Issue 2044023005: Make PropertyReference value() return a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

index 9b47f4a4a2432625175365636c99dc60dce64765..c43b66b1cf4046aa59059975e65b927dba1c7adf 100644

--- a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

@@ -154,16 +154,16 @@ HeapVector<StylePropertyMap::StylePropertyMapEntry> InlineStylePropertyMap::getI

String name;

CSSStyleValueOrCSSStyleValueSequence value;

if (propertyID == CSSPropertyVariable) {

- const CSSCustomPropertyDeclaration* customDeclaration = toCSSCustomPropertyDeclaration(propertyReference.value());

- name = customDeclaration->name();

+ const CSSCustomPropertyDeclaration& customDeclaration = toCSSCustomPropertyDeclaration(propertyReference.value());

+ name = customDeclaration.name();

// TODO(meade): Eventually custom properties will support other types, so actually return them instead of always returning a CSSUnsupportedStyleValue.

- value.setCSSStyleValue(CSSUnsupportedStyleValue::create(customDeclaration->customCSSText()));

+ value.setCSSStyleValue(CSSUnsupportedStyleValue::create(customDeclaration.customCSSText()));

} else if (propertyID == CSSPropertyApplyAtRule) {

name = "@apply";

- value.setCSSStyleValue(CSSUnsupportedStyleValue::create(toCSSCustomIdentValue(propertyReference.value())->value()));

+ value.setCSSStyleValue(CSSUnsupportedStyleValue::create(toCSSCustomIdentValue(propertyReference.value()).value()));

} else {

name = getPropertyNameString(propertyID);

- CSSStyleValueVector styleValueVector = StyleValueFactory::cssValueToStyleValueVector(propertyID, *propertyReference.value());

+ CSSStyleValueVector styleValueVector = StyleValueFactory::cssValueToStyleValueVector(propertyID, propertyReference.value());

if (styleValueVector.size() == 1)

value.setCSSStyleValue(styleValueVector[0]);

else